Fix more shellcheck errors

ZcashFoundation · Nov 23, 2022 · 3b46d1e · 3b46d1e
1 parent f1abb32
commit 3b46d1e
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/.github/workflows/continous-delivery.yml b/.github/workflows/continous-delivery.yml
@@ -113,7 +113,7 @@ jobs:
       - name: Downcase network name for labels
         run: |
           NETWORK_CAPS="${{ inputs.network || 'Mainnet' }}"
-          echo "NETWORK=${NETWORK_CAPS,,}" >> $GITHUB_ENV
+          echo "NETWORK=${NETWORK_CAPS,,}" >> "$GITHUB_ENV"
 
       # Setup gcloud CLI
       - name: Authenticate to Google Cloud

diff --git a/.github/workflows/deploy-gcp-tests.yml b/.github/workflows/deploy-gcp-tests.yml
@@ -134,7 +134,7 @@ jobs:
       - name: Downcase network name for labels
         run: |
           NETWORK_CAPS="${{ inputs.network }}"
-          echo "NETWORK=${NETWORK_CAPS,,}" >> $GITHUB_ENV
+          echo "NETWORK=${NETWORK_CAPS,,}" >> "$GITHUB_ENV"
 
       # Install our SSH secret
       - name: Install private SSH key
@@ -286,7 +286,7 @@ jobs:
       - name: Downcase network name for disks and labels
         run: |
           NETWORK_CAPS="${{ inputs.network }}"
-          echo "NETWORK=${NETWORK_CAPS,,}" >> $GITHUB_ENV
+          echo "NETWORK=${NETWORK_CAPS,,}" >> "$GITHUB_ENV"
 
       # Install our SSH secret
       - name: Install private SSH key
@@ -396,8 +396,8 @@ jobs:
           echo "Selected Disk: $CACHED_DISK_NAME"
           echo "::set-output name=cached_disk_name::$CACHED_DISK_NAME"
 
-          echo "STATE_VERSION=$LOCAL_STATE_VERSION" >> $GITHUB_ENV
-          echo "CACHED_DISK_NAME=$CACHED_DISK_NAME" >> $GITHUB_ENV
+          echo "STATE_VERSION=$LOCAL_STATE_VERSION" >> "$GITHUB_ENV"
+          echo "CACHED_DISK_NAME=$CACHED_DISK_NAME" >> "$GITHUB_ENV"
 
       # Create a Compute Engine virtual machine and attach a cached state disk using the
       # $CACHED_DISK_NAME variable as the source image to populate the disk cached state
@@ -1312,9 +1312,9 @@ jobs:
       - name: Format network name and branch name for disks
         run: |
           NETWORK_CAPS="${{ inputs.network }}"
-          echo "NETWORK=${NETWORK_CAPS,,}" >> $GITHUB_ENV
+          echo "NETWORK=${NETWORK_CAPS,,}" >> "$GITHUB_ENV"
           LONG_GITHUB_REF="${{ env.GITHUB_REF_SLUG_URL }}"
-          echo "SHORT_GITHUB_REF=${LONG_GITHUB_REF:0:12}" >> $GITHUB_ENV
+          echo "SHORT_GITHUB_REF=${LONG_GITHUB_REF:0:12}" >> "$GITHUB_ENV"
 
       # Install our SSH secret
       - name: Install private SSH key
@@ -1347,7 +1347,7 @@ jobs:
           LOCAL_STATE_VERSION=$(grep -oE "DATABASE_FORMAT_VERSION: .* [0-9]+" $GITHUB_WORKSPACE/zebra-state/src/constants.rs | grep -oE "[0-9]+" | tail -n1)
           echo "STATE_VERSION: $LOCAL_STATE_VERSION"
 
-          echo "STATE_VERSION=$LOCAL_STATE_VERSION" >> $GITHUB_ENV
+          echo "STATE_VERSION=$LOCAL_STATE_VERSION" >> "$GITHUB_ENV"
 
       # Sets the $UPDATE_SUFFIX env var to "-u" if updating a previous cached state,
       # and the empty string otherwise.
@@ -1369,8 +1369,8 @@ jobs:
           # We're going to delete old images after a few days, so we only need the time here
           TIME_SUFFIX=$(date '+%H%M%S' --utc)
 
-          echo "UPDATE_SUFFIX=$UPDATE_SUFFIX" >> $GITHUB_ENV
-          echo "TIME_SUFFIX=$TIME_SUFFIX" >> $GITHUB_ENV
+          echo "UPDATE_SUFFIX=$UPDATE_SUFFIX" >> "$GITHUB_ENV"
+          echo "TIME_SUFFIX=$TIME_SUFFIX" >> "$GITHUB_ENV"
 
       # Get the sync height from the test logs, which is later used as part of the
       # disk description and labels.
@@ -1412,7 +1412,7 @@ jobs:
           fi
 
           echo "Found sync height in logs: $SYNC_HEIGHT"
-          echo "SYNC_HEIGHT=$SYNC_HEIGHT" >> $GITHUB_ENV
+          echo "SYNC_HEIGHT=$SYNC_HEIGHT" >> "$GITHUB_ENV"
 
       # Get the original cached state height from google cloud.
       #
@@ -1433,7 +1433,7 @@ jobs:
               echo "$CACHED_DISK_NAME height: $ORIGINAL_HEIGHT"
           fi
 
-          echo "ORIGINAL_HEIGHT=$ORIGINAL_HEIGHT" >> $GITHUB_ENV
+          echo "ORIGINAL_HEIGHT=$ORIGINAL_HEIGHT" >> "$GITHUB_ENV"
 
       # Create an image from the state disk, which will be used for any tests that start
       # after it is created. These tests can be in the same workflow, or in a different PR.

diff --git a/.github/workflows/zcashd-manual-deploy.yml b/.github/workflows/zcashd-manual-deploy.yml
@@ -46,7 +46,7 @@ jobs:
       - name: Format network name for labels
         run: |
           NETWORK_CAPS="${{ inputs.network }}"
-          echo "NETWORK=${NETWORK_CAPS,,}" >> $GITHUB_ENV
+          echo "NETWORK=${NETWORK_CAPS,,}" >> "$GITHUB_ENV"
 
       # Setup gcloud CLI
       - name: Authenticate to Google Cloud