Map out block validation data flow #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That build failure is very weird:
|
I wonder if crates.io is having a hard time with new Rust 1.45.0 release? |
|
What the hell
|
dconnolly
added
A-consensus
teor2345
reviewed
Jul 31, 2020
| - https://github.com/zcash/zcash/blob/ab2b7c0969391d8a57d90d008665da02f3f618e7/src/pow.cpp#L96 | ||
| - requires no information except `n`, `k` params | ||
| - checks that the proof of work parameters are valid | ||
| - requires the current proof of work amount `params.powLimit` |
There was a problem hiding this comment.
Added to the consensus parameters tracking issue #565
teor2345
reviewed
Jul 31, 2020
| - Calls `ContextualCheckBlockHeader`, defined at: https://github.com/zcash/zcash/blob/ab2b7c0969391d8a57d90d008665da02f3f618e7/src/main.cpp#L3900 | ||
| - Does checks given a pointer to the previous block | ||
| - Check Equihash solution is valid | ||
| - In our code we compute the equihash solution on the block alone, we will need to also do a step to check that its block height is the appopriate N+1 re: the previous block |
teor2345
reviewed
Jul 31, 2020
| - Does checks given a pointer to the previous block | ||
| - Check Equihash solution is valid | ||
| - In our code we compute the equihash solution on the block alone, we will need to also do a step to check that its block height is the appopriate N+1 re: the previous block | ||
| - Check proof of work |
teor2345
reviewed
Jul 31, 2020
teor2345
reviewed
Jul 31, 2020
| - https://github.com/zcash/zcash/blob/ab2b7c0969391d8a57d90d008665da02f3f618e7/src/main.cpp#L4040 | ||
| - Reject block.nVersion < 4 blocks | ||
| - Don't accept any forks from the main chain prior to last checkpoint | ||
| - We will probably get this 'more naturally' and don't need to explicitly check it like this |
There was a problem hiding this comment.
CheckpointVerifier effectively does this, and when we don't have hard-coded checkpoints, the parallel verification RFC should handle it #763
teor2345
reviewed
Jul 31, 2020
| - Calls `ContextualCheckBlock`, defined at https://github.com/zcash/zcash/blob/ab2b7c0969391d8a57d90d008665da02f3f618e7/src/main.cpp#L4065 | ||
| - For each transaction: | ||
| - Calls `ContextualCheckTransaction`, defined at https://github.com/zcash/zcash/blob/ab2b7c0969391d8a57d90d008665da02f3f618e7/src/main.cpp#L760 | ||
| - For Zebra, we should only be doing Transaction v4 (Sapling+) checks, because checkpointing |
There was a problem hiding this comment.
Do we need to keep context from v1-v3 transactions, so we can verify v4 transactions?
For example, UTXOs and revealed nullifiers.
There was a problem hiding this comment.
So, we might have to compute the treestate including nullifier set that is correct at the final checkpoint?
There was a problem hiding this comment.
To answer your question, "I'm not sure"
teor2345
reviewed
Jul 31, 2020
| - Calls `IsFinalTx`, defined at https://github.com/zcash/zcash/blob/ab2b7c0969391d8a57d90d008665da02f3f618e7/src/main.cpp#L675 | ||
| - Calls tx::IsFinal(): https://github.com/zcash/zcash/blob/6d9573c66e33b5b742c49ab35e816d74d4ab55b1/src/primitives/transaction.h#L401 | ||
| - Enforce BIP 34: https://github.com/zcash/zcash/blob/ab2b7c0969391d8a57d90d008665da02f3f618e7/src/main.cpp#L4090 | ||
| - If blockheight < the block just before the first subsidy halving block, dispense Founder's Reward: https://github.com/zcash/zcash/blob/ab2b7c0969391d8a57d90d008665da02f3f618e7/src/main.cpp#L4104 |
teor2345
reviewed
Jul 31, 2020
| - If blockheight < the block just before the first subsidy halving block, dispense Founder's Reward: https://github.com/zcash/zcash/blob/ab2b7c0969391d8a57d90d008665da02f3f618e7/src/main.cpp#L4104 | ||
| - Everything else is state/index management after good verification | ||
| - Calls `CheckBlockIndex`, defined at https://github.com/zcash/zcash/blob/ab2b7c0969391d8a57d90d008665da02f3f618e7/src/main.cpp#L5125 | ||
| - Calls `ActivateBestChain`, defined at https://github.com/zcash/zcash/blob/ab2b7c0969391d8a57d90d008665da02f3f618e7/src/main.cpp#L3513 |
There was a problem hiding this comment.
See the parallel verification RFC #763
teor2345
approved these changes
Jul 31, 2020
|
Is this good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #529