Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue: Validate coinbase transactions, including the dev fund #801

Closed
1 of 9 tasks
teor2345 opened this issue Jul 31, 2020 · 1 comment · Fixed by #3067
Closed
1 of 9 tasks

Tracking Issue: Validate coinbase transactions, including the dev fund #801

teor2345 opened this issue Jul 31, 2020 · 1 comment · Fixed by #3067
Assignees
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement C-tracking-issue Category: This is a tracking issue for other tasks Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped NU-1 Sapling Network Upgrade: Sapling specific tasks NU-2 Blossom Network Upgrade: Blossom specific tasks NU-3 Heartwood Network Upgrade: Heartwood specific tasks NU-4 Canopy Network Upgrade: Canopy specific tasks NU-5 Network Upgrade: NU5 specific tasks

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jul 31, 2020

Motivation

We need to validate coinbase transactions.

Since we're checkpointing on Canopy, we can ignore Founders Reward validation.

Tasks

Overall ticket: #338

Canopy onwards:

Testing:

  • Create test blocks that send multiple outputs to a funding stream address
    • correct address, different amount
    • different address, correct amounts
    • correct address, correct amount, multiple times
    • correct address, multiple transfers that sum to correct amount (should fail)
    • these tests should pass if there is at least one transfer to the correct address with the correct amount, and fail otherwise

Canopy until second halving:

  • dev fund: funding stream amounts, addresses, and height ranges
    • Mainnet
    • Testnet
  • test blocks between Canopy and first halving on testnet: they must obey the dev fund rules
  • test blocks after first halving on mainnet and testnet
@teor2345 teor2345 added Poll::Ready A-consensus Area: Consensus rule updates NU-1 Sapling Network Upgrade: Sapling specific tasks A-rust Area: Updates to Rust code NU-3 Heartwood Network Upgrade: Heartwood specific tasks NU-4 Canopy Network Upgrade: Canopy specific tasks NU-2 Blossom Network Upgrade: Blossom specific tasks C-enhancement Category: This is an improvement labels Jul 31, 2020
@teor2345 teor2345 added this to the Validate transactions. milestone Jul 31, 2020
@teor2345 teor2345 changed the title Validate coinbase, founders reward, and dev fund Tracking Issue: Validate coinbase, founders reward, and dev fund Aug 27, 2020
@yaahc yaahc added the C-tracking-issue Category: This is a tracking issue for other tasks label Sep 4, 2020
@teor2345
Copy link
Contributor Author

Updated to add transaction fees, and correct the network upgrades for each check.

@mpguerra mpguerra added the Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped label Nov 17, 2020
teor2345 added a commit to teor2345/zebra that referenced this issue Nov 24, 2020
Funding stream block subsidy validation will be implemented as part of
block subsidy validation in ZcashFoundation#801.
dconnolly pushed a commit that referenced this issue Nov 24, 2020
Funding stream block subsidy validation will be implemented as part of
block subsidy validation in #801.
@mpguerra mpguerra removed this from the Transaction Validation milestone Jan 5, 2021
@mpguerra mpguerra added the NU-5 Network Upgrade: NU5 specific tasks label Jan 15, 2021
@teor2345 teor2345 changed the title Tracking Issue: Validate coinbase, founders reward, and dev fund Tracking Issue: Validate coinbase and dev fund Mar 8, 2021
@mpguerra mpguerra removed the E-med label Mar 23, 2021
@teor2345 teor2345 added this to the 2021 Sprint 8 milestone Mar 31, 2021
@mpguerra mpguerra removed this from the 2021 Sprint 10 milestone May 4, 2021
@teor2345 teor2345 changed the title Tracking Issue: Validate coinbase and dev fund Tracking Issue: Validate coinbase inputs and outputs, including the dev fund Jun 17, 2021
@teor2345 teor2345 changed the title Tracking Issue: Validate coinbase inputs and outputs, including the dev fund Tracking Issue: Validate coinbase transactions, including the dev fund Jun 24, 2021
@mpguerra mpguerra linked a pull request Nov 23, 2021 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement C-tracking-issue Category: This is a tracking issue for other tasks Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped NU-1 Sapling Network Upgrade: Sapling specific tasks NU-2 Blossom Network Upgrade: Blossom specific tasks NU-3 Heartwood Network Upgrade: Heartwood specific tasks NU-4 Canopy Network Upgrade: Canopy specific tasks NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants