Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Improve Zebra acceptance test diagnostics #4958

Merged
merged 4 commits into from
Aug 28, 2022
Merged

Conversation

teor2345
Copy link
Contributor

Motivation

@oxarbitrage and I worked on a bunch of testing improvements earlier this week, this PR implements some of those improvements.

Solution

  • Show the arguments of acceptance test functions in the logs
  • Show all the logs in the "Run tests" jobs
  • Document expected "broken pipe" error from tee

Review

@oxarbitrage is probably the best person to review this PR. We want it in CI soon, so it's easier to diagnose test errors.

Reviewer Checklist

  • Changes make sense

@teor2345 teor2345 added A-rust Area: Updates to Rust code A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 I-usability Zebra is hard to understand or use C-testing Category: These are tests labels Aug 26, 2022
@teor2345 teor2345 requested a review from oxarbitrage August 26, 2022 04:05
@teor2345 teor2345 self-assigned this Aug 26, 2022
@teor2345 teor2345 requested review from a team as code owners August 26, 2022 04:05
@teor2345 teor2345 requested review from gustavovalverde and removed request for a team August 26, 2022 04:05
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #4958 (bbc7c4a) into main (1d861b0) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4958      +/-   ##
==========================================
- Coverage   79.04%   79.03%   -0.02%     
==========================================
  Files         309      309              
  Lines       38781    38781              
==========================================
- Hits        30656    30652       -4     
- Misses       8125     8129       +4     

Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I'll leave the final approval to @oxarbitrage

Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this one as it LGTM and if an improvement needs to be done, it can be done in another PR. In the meanwhile we'll be needing this fixes to troubleshoot all the coming PRs to main in the following days

@teor2345
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2022

update

✅ Branch has been successfully updated

mergify bot added a commit that referenced this pull request Aug 28, 2022
@mergify mergify bot merged commit 4cda4ee into main Aug 28, 2022
@mergify mergify bot deleted the diagnostic-fixes branch August 28, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-rust Area: Updates to Rust code C-testing Category: These are tests I-usability Zebra is hard to understand or use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants