-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Improve Zebra acceptance test diagnostics #4958
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4958 +/- ##
==========================================
- Coverage 79.04% 79.03% -0.02%
==========================================
Files 309 309
Lines 38781 38781
==========================================
- Hits 30656 30652 -4
- Misses 8125 8129 +4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but I'll leave the final approval to @oxarbitrage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this one as it LGTM and if an improvement needs to be done, it can be done in another PR. In the meanwhile we'll be needing this fixes to troubleshoot all the coming PRs to main
in the following days
@Mergifyio update |
✅ Branch has been successfully updated |
Motivation
@oxarbitrage and I worked on a bunch of testing improvements earlier this week, this PR implements some of those improvements.
Solution
tee
Review
@oxarbitrage is probably the best person to review this PR. We want it in CI soon, so it's easier to diagnose test errors.
Reviewer Checklist