-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): Show full Zebra test panic details in CI logs #4942
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4942 +/- ##
==========================================
+ Coverage 79.04% 79.11% +0.06%
==========================================
Files 309 309
Lines 38781 38830 +49
==========================================
+ Hits 30656 30720 +64
+ Misses 8125 8110 -15 |
Now we know what the panic bug is, this isn't a critical priority any more. |
6b7d2e1
to
92afab9
Compare
Marking this as critical because we're still seeing panics, and we need to know what they are. So we want to merge this first. |
92afab9
to
7150bd9
Compare
@Mergifyio update |
✅ Branch has been successfully updated |
8a0996d
to
3eeb3a3
Compare
@Mergifyio update |
✅ Branch has been successfully updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as this is critical and CI is passing.
Motivation
We're seeing some Zebra panics in CI. Our custom test harness just reports "The application panicked (crashed).", with no details.
Example logs:
https://github.com/ZcashFoundation/zebra/runs/7981879420?check_suite_focus=true#step:6:1103
Depends-On: #4945
Solution
Related refactors:
ignore_exited
argument to test child processkill()
Related changes:
Review
This is an urgent fix, so we can see panic details in our CI logs.
Reviewer Checklist