-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(deps): upgrade zcash_script and zcash dependencies #4926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4926 +/- ##
==========================================
+ Coverage 79.16% 79.29% +0.12%
==========================================
Files 310 310
Lines 38900 38900
==========================================
+ Hits 30797 30844 +47
+ Misses 8103 8056 -47 |
conradoplg
requested review from
arya2 and
upbqdn
and removed request for
a team
August 31, 2022 22:37
teor2345
previously approved these changes
Sep 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is a big improvement!
teor2345
added
A-dependencies
Area: Dependency file updates
A-rust
Area: Updates to Rust code
C-enhancement
Category: This is an improvement
P-Medium ⚡
I-slow
Problems with performance or responsiveness
labels
Sep 2, 2022
teor2345
force-pushed
the
update-zcash
branch
from
September 2, 2022 02:52
722b027
to
71a2f1a
Compare
I updated Cargo.lock to resolve merge conflicts with |
teor2345
approved these changes
Sep 2, 2022
This was referenced Sep 2, 2022
This was referenced Sep 2, 2022
This was referenced Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-dependencies
Area: Dependency file updates
A-rust
Area: Updates to Rust code
C-enhancement
Category: This is an improvement
I-slow
Problems with performance or responsiveness
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #4767
To do that we must update
zcash_script
and related dependencies.Specifications
Designs
Solution
Update
zcash_script
which allows us to upgrade the zcash dependencies.Updates
zcash_proofs
to upstream again and not our fork, after the Sprout params downloading code was merged.Closes #4767
Review
This PR is blocked on:
This may take a while so let's not wait for itzcash_proofs
being released so that we don't depend on a git commit, which will allow us to remove duplicated dependencies (optional; we may skip this if we want)Reviewer Checklist
Follow Up Work