-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate orchard
crates, change dependencies to zcash/librustzcash
#4767
Comments
@conradoplg I think you were the last person to update these dependencies, did we deliberately allow duplicates? |
This was blocked by zcashd dependencies being updated, but 5.1.0 was released 3 days ago, we can now update zcash_script and remove these Lines 34 to 38 in c4f89ed
The last one is caused by our zcash_proofs fork IIRC |
To make all our dependencies to use the |
Our |
orchard
cratesorchard
crates, change dependencies to zcash/librustzcash
Motivation
We're currently compiling 3 different versions of the
orchard
crates into Zebra:Since we're having some trouble with slow syncs, we want to be using the latest version of
halo2
in all our code.Tasks
Change dependencies:
ZcashFoundation/librustzcash
dependency tozcash/librustzcash
, either using themain
branch, or a release after Download sprout parameters in zcash_proofs zcash/librustzcash#459 got mergedDuplicate dependencies:
cargo tree
to find how these duplicates are happeningCargo.toml
deny.toml
The text was updated successfully, but these errors were encountered: