Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): Copy lightwalletd from the correct path during Docker builds #4886

Merged
merged 3 commits into from
Aug 4, 2022
Merged

fix(docker): Copy lightwalletd from the correct path during Docker builds #4886

merged 3 commits into from
Aug 4, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Aug 4, 2022 •
edited
Loading

Motivation

After PR #4786 merged to main, new builds started failing because the Docker lightwalletd binary path changed:

Error: buildx failed with: error: failed to solve: failed to compute cache key: failed to calculate checksum of ref uolxlp2jcfip5a0uijnmc10kf::mqxvue803jy58xssyqyxm7uyp: "/lightwalletd": not found

https://github.com/ZcashFoundation/zebra/runs/7663736881?check_suite_focus=true#step:8:484

Solution

  • Use the correct lightwalletd binary path to copy to the Zebra Dockerfile

related fixes:

  • Use the correct lightwalletd binary path in the build stage entrypoint in the lightwalletd Dockerfile

Review

This is an urgent fix to get PRs building again.

Reviewer Checklist

  • CI passes

Follow Up Work

#4612 would have caught this, it's scheduled for next sprint.

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Critical 🚑 I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd labels Aug 4, 2022
@teor2345 teor2345 self-assigned this Aug 4, 2022
@teor2345 teor2345 marked this pull request as ready for review August 4, 2022 04:11
@teor2345 teor2345 requested a review from a team as a code owner August 4, 2022 04:11
@teor2345 teor2345 requested review from conradoplg and removed request for a team August 4, 2022 04:12
@teor2345 teor2345 changed the title Copy lightwalletd from the updated Docker path fix(docker): Copy lightwalletd from the updated path Aug 4, 2022
@teor2345 teor2345 mentioned this pull request Aug 4, 2022
Closed
@teor2345 teor2345 changed the title fix(docker): Copy lightwalletd from the updated path fix(docker): Copy lightwalletd from the correct path during Docker builds Aug 4, 2022
@mergify mergify bot merged commit f804ff6 into main Aug 4, 2022
@mergify mergify bot deleted the fix-lwd-build branch August 4, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

@conradoplg conradoplg Awaiting requested review from conradoplg conradoplg is a code owner automatically assigned from ZcashFoundation/devops-reviewers

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @dconnolly