refactor(build): use FHS for deployments and artifacts #4786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavovalverde
added
A-infrastructure
teor2345
reviewed
Jul 31, 2022
|
@Mergifyio update |
✅ Branch has been successfully updated |
teor2345
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Looks good!
The zcash-params job doesn't actually run until we merge to main, so can you please check main and the next PR that builds off the new zcash-params image?
(We did it this way because we didn't want to overload the parameter download server and get rate-limited.)
This was referenced Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Linux has its own filesystem convention, which is standard and considered by most sysadmins when creating products, OS-level restrictions, and even when taking security measures.
We should use this convention in our deployments and artifacts, so we don't get constrained in platforms which had restrictions based on this convention.
Fixes #3432
Specifications
Filesystem Hierarchy Standard - v3.0: https://refspecs.linuxfoundation.org/FHS_3.0/fhs-3.0.html
Linux man for
hier: https://man7.org/linux/man-pages/man7/hier.7.htmlSolution
Do not use the
/appdirectory to keep build binaries, as this does not comply with FHS. The correct place is/opt/<app-name>Review
Anyone from @ZcashFoundation/devops-reviewers
Reviewer Checklist