fix(test): use FuturesOrdered in fallback_verification test #4867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4867 +/- ##
==========================================
- Coverage 78.86% 78.76% -0.11%
==========================================
Files 305 305
Lines 38780 38780
==========================================
- Hits 30583 30544 -39
- Misses 8197 8236 +39 |
teor2345
approved these changes
Aug 2, 2022
teor2345
added
C-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
fallback_verificationtest assumed futures would be completed in order, but usedFuturesUnorderedSpecifications
Designs
Solution
Use
FuturesOrderedinstead.Closes #4845
Review
I couldn't replicate the issue locally, so I can't be sure if it really fixes it, but it seems to be the proper fix.
Reviewer Checklist
Follow Up Work