Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unstable fallback_verification test #4845

Closed
teor2345 opened this issue Jul 30, 2022 · 1 comment · Fixed by #4867
Closed

Fix unstable fallback_verification test #4845

teor2345 opened this issue Jul 30, 2022 · 1 comment · Fixed by #4867
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures S-needs-investigation Status: Needs further investigation

Comments

@teor2345
Copy link
Contributor

Motivation

I've seen this test fail once:

The application panicked (crashed).
Message: assertion failed: result.is_err()
Location: tower-batch/tests/ed25519.rs:46

https://github.com/ZcashFoundation/zebra/runs/7571394634?check_suite_focus=true#step:3:162

Tasks

Work out why the test is failing, and fix it
@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code S-needs-triage Status: A bug report needs triage S-needs-investigation Status: Needs further investigation P-Low ❄️ I-integration-fail Continuous integration fails, including build and test failures labels Jul 30, 2022
@teor2345 teor2345 changed the title Fix unstable dallback_verification test Fix unstable fallback_verification test Jul 30, 2022
@teor2345 teor2345 mentioned this issue Aug 1, 2022
Merged
@teor2345
Copy link
Contributor Author

teor2345 commented Aug 1, 2022

I saw it fail again:
https://github.com/ZcashFoundation/zebra/runs/7608023674?check_suite_focus=true#step:13:689

@conradoplg conradoplg mentioned this issue Aug 2, 2022
Merged
3 tasks
@mergify mergify bot closed this as completed in #4867 Aug 2, 2022
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures S-needs-investigation Status: Needs further investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(test): use FuturesOrdered in fallback_verification test ZcashFoundation/zebra
2 participants
@mpguerra @teor2345