-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn the user when Zebra doesn't recognize the format of zebrad.toml
#4689
Conversation
e96079a
to
38adb6e
Compare
38adb6e
to
c93bd89
Compare
Codecov Report
@@ Coverage Diff @@
## main #4689 +/- ##
==========================================
+ Coverage 78.83% 78.92% +0.08%
==========================================
Files 304 304
Lines 37506 37508 +2
==========================================
+ Hits 29568 29602 +34
+ Misses 7938 7906 -32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I did a merge with PR #4676 and added some comments.
ca9e034
to
854544b
Compare
854544b
to
7465d78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fixes!
Motivation
When the format of zebrad.toml changes, Zebra doesn't recognize it appropriately and returns an unclear error saying that it couldn't read some data. This becomes an issue when users install a new version of Zebra that uses a new format of zebrad.toml, but keep their old
zebrad.toml
file.Solution
Zebra now provides a message saying that it could not parse the provided config file, and suggests that the user might be using a deprecated format of the file.
Close #4665
Reviewer Checklist