-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(config): Add tests for old configs #4676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, I think I found a way to avoid using the git checkout paths.
Codecov Report
@@ Coverage Diff @@
## main #4676 +/- ##
==========================================
+ Coverage 78.86% 78.90% +0.03%
==========================================
Files 304 304
Lines 37506 37506
==========================================
+ Hits 29580 29593 +13
+ Misses 7926 7913 -13 |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
Motivation
We want to add tests for breaking changes in our config. Closes #4625
Solution
I had to change the type of the peer set fields in the config to
IndexSet
, so the peers are always displayed in the same order. I eventually compare two configs to be equal. This work is done in 7adada8Tests are static config file intro is done in f7053b0
Review
I think anyone can review.
Reviewer Checklist