Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(config): Add tests for old configs #4676

Merged
merged 13 commits into from
Jun 27, 2022
Merged

tests(config): Add tests for old configs #4676

merged 13 commits into from
Jun 27, 2022

Conversation

oxarbitrage
Copy link
Contributor

Motivation

We want to add tests for breaking changes in our config. Closes #4625

Solution

I had to change the type of the peer set fields in the config to IndexSet , so the peers are always displayed in the same order. I eventually compare two configs to be equal. This work is done in 7adada8

Tests are static config file intro is done in f7053b0

Review

I think anyone can review.

Reviewer Checklist

  • Added tests make sense and pass

@oxarbitrage oxarbitrage requested review from a team as code owners June 22, 2022 22:11
@oxarbitrage oxarbitrage requested review from teor2345 and removed request for a team June 22, 2022 22:11
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, I think I found a way to avoid using the git checkout paths.

zebrad/tests/acceptance.rs Outdated Show resolved Hide resolved
zebrad/tests/common/config.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #4676 (c98c056) into main (6aea0fd) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4676      +/-   ##
==========================================
+ Coverage   78.86%   78.90%   +0.03%     
==========================================
  Files         304      304              
  Lines       37506    37506              
==========================================
+ Hits        29580    29593      +13     
+ Misses       7926     7913      -13     

@teor2345

This comment was marked as resolved.

@teor2345 teor2345 added I-usability Zebra is hard to understand or use C-testing Category: These are tests labels Jun 26, 2022
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

mergify bot added a commit that referenced this pull request Jun 26, 2022
@mergify mergify bot merged commit 83aa42e into main Jun 27, 2022
@mergify mergify bot deleted the issue4625 branch June 27, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-testing Category: These are tests I-usability Zebra is hard to understand or use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test that old zebrad.toml files still work
3 participants