Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump indexmap from 1.8.2 to 1.9.1 #4671

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 22, 2022

Depends-On: #4676

This PR will need a @dependabot recreate after the other PR merges.

Bumps indexmap from 1.8.2 to 1.9.1.

Changelog

Sourced from indexmap's changelog.

  • 1.9.1

    • The MSRV now allows Rust 1.56.0 as well. However, currently hashbrown 0.12.1 requires 1.56.1, so users on 1.56.0 should downgrade that to 0.12.0 until there is a later published version relaxing its requirement.
  • 1.9.0

    • MSRV: Rust 1.56.1 or later is now required.

    • The hashbrown dependency has been updated to version 0.12.

    • IterMut and ValuesMut now implement Debug.

    • The new IndexMap::shrink_to and IndexSet::shrink_to methods shrink the capacity with a lower bound.

    • The new IndexMap::move_index and IndexSet::move_index methods change the position of an item from one index to another, shifting the items between to accommodate the move.

Commits
  • a638b99 Merge pull request #233 from cuviper/release-1.9.1
  • 3f6cdde Release 1.9.1
  • 3f8381a Run CI on 1.56.1 until next hashbrown release
  • 24a0c8f Revert "Bump MSRV to 1.56.1, matching hashbrown as of 0.12.1"
  • 844750f Fix the RELEASES.md link
  • 3222203 Merge pull request #231 from cuviper/release-1.9.0
  • 9eda24a Add a release note for move_index
  • 8d02160 Use u8 test indices so quickcheck is less likely to go out of bounds.
  • be700ef Add move_index to change the position of an entry
  • 511280a Add an MSRV note for retain_mut
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner June 22, 2022 15:50
@dependabot dependabot bot requested review from teor2345 and removed request for a team June 22, 2022 15:50
@dependabot dependabot bot added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code P-Low ❄️ labels Jun 22, 2022
@dependabot dependabot bot requested a review from dconnolly June 22, 2022 15:50
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #4671 (a20233a) into main (83aa42e) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4671      +/-   ##
==========================================
- Coverage   78.87%   78.79%   -0.09%     
==========================================
  Files         304      304              
  Lines       37506    37506              
==========================================
- Hits        29583    29551      -32     
- Misses       7923     7955      +32     

Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an addition of unsafe but only after an assert to check the bounds of that's being done inside that block:

image

dconnolly
dconnolly previously approved these changes Jun 23, 2022
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the note about the safely checked usage of unsafe, currently blocked from merging until config change tests are merged

@dconnolly
Copy link
Contributor

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2022

update

✅ Branch has been successfully updated

@teor2345
Copy link
Contributor

@dependabot recreate

Bumps [indexmap](https://github.com/bluss/indexmap) from 1.8.2 to 1.9.1.
- [Release notes](https://github.com/bluss/indexmap/releases)
- [Changelog](https://github.com/bluss/indexmap/blob/master/RELEASES.md)
- [Commits](indexmap-rs/indexmap@1.8.2...1.9.1)

---
updated-dependencies:
- dependency-name: indexmap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/indexmap-1.9.1 branch from 02dead4 to a20233a Compare June 27, 2022 06:16
@dependabot dependabot bot requested a review from a team as a code owner June 27, 2022 06:16
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving with new dependency usage from main

@mergify mergify bot merged commit e709420 into main Jun 27, 2022
@mergify mergify bot deleted the dependabot/cargo/indexmap-1.9.1 branch June 27, 2022 07:37
upbqdn pushed a commit that referenced this pull request Jun 27, 2022
Bumps [indexmap](https://github.com/bluss/indexmap) from 1.8.2 to 1.9.1.
- [Release notes](https://github.com/bluss/indexmap/releases)
- [Changelog](https://github.com/bluss/indexmap/blob/master/RELEASES.md)
- [Commits](indexmap-rs/indexmap@1.8.2...1.9.1)

---
updated-dependencies:
- dependency-name: indexmap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants