-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): build each crate individually #4640
Conversation
671b305
to
3bcd8a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some things I noticed, happy to leave someone else to do the full review.
Are we going to make all these jobs required in CI?
That seems like a lot of jobs to add, we might want to think about making a final job that depends on all of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for this!
I have this list of tasks ready to go in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add patch jobs to this PR?
We need them if we want to require these jobs in CI.
patch file added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can delete some redundant config lines, but it doesn't really matter either way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's merge and see how we go
Motivation
Sometimes we add code that needs a feature to a Zebra crate, then activate that feature in
zebrad
. But we forget to activate the feature in the crate that actually contains the code.For an example, see PR #1365, where individual crates use features in their dependencies, but don't declare those features in their
Cargo.toml
.Fixes #1364
Fixes #4550
Designs
Solution
fail-fast
strategy, as we don't want to keep consuming minutes if a crate build failedReview
Not ready
Reviewer Checklist
Follow Up Work
It would be better to generate the crate names automatically, but this task would need further analysis to be able to generate a file with the needed GHA format for a matrix.