Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Rust builds when .cargo/config.toml or clippy.toml change #4652

Closed
teor2345 opened this issue Jun 20, 2022 · 0 comments · Fixed by #4941
Closed

Run Rust builds when .cargo/config.toml or clippy.toml change #4652

teor2345 opened this issue Jun 20, 2022 · 0 comments · Fixed by #4941
Assignees
@gustavovalverde
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-diagnostics Area: Diagnosing issues or monitoring performance C-bug Category: This is a bug C-testing Category: These are tests I-build-fail Zebra fails to build

Comments

@teor2345
Copy link
Contributor

Motivation

Changes to these files can affect CI results, because they change warnings and errors:

We should add these files to all our CI jobs that run builds (including the test jobs, because they build tests).

Originally posted by @teor2345 in #4640 (comment)
@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡ A-diagnostics Area: Diagnosing issues or monitoring performance C-testing Category: These are tests I-build-fail Zebra fails to build C-bug Category: This is a bug labels Jun 20, 2022
@teor2345 teor2345 mentioned this issue Jun 20, 2022
Merged
3 tasks
@teor2345 teor2345 changed the title Run builds when .cargo/config.toml or clippy.toml change Run Rust builds when .cargo/config.toml or clippy.toml change Jul 7, 2022
@gustavovalverde gustavovalverde mentioned this issue Aug 24, 2022
Merged
@gustavovalverde gustavovalverde self-assigned this Aug 24, 2022
@mergify mergify bot closed this as completed in #4941 Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gustavovalverde gustavovalverde

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-diagnostics Area: Diagnosing issues or monitoring performance C-bug Category: This is a bug C-testing Category: These are tests I-build-fail Zebra fails to build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(test): run build and test jobs on cargo and clippy config changes ZcashFoundation/zebra
2 participants
@teor2345 @gustavovalverde