Release Blocker: Stop trying to verify coinbase inputs using the script verifier #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And create tests to catch similar bugs earier.
teor2345
added
C-bug
3 tasks
jvff
previously approved these changes
Jun 28, 2021
| let result = verifier | ||
| .oneshot(Request::Block { | ||
| transaction: Arc::new(transaction), | ||
| known_utxos: Arc::new(known_utxos), |
There was a problem hiding this comment.
Nit: I'd remove the known_utxos variable to avoid the impression that there are any known UTXOs in the test.
Suggested change
| known_utxos: Arc::new(known_utxos), | |
| known_utxos: Arc::new(HashMap::new()), |
Comment on lines
+446
to
+448
| // TODO: Remove `should_panic` once the NU5 activation heights for testnet and mainnet have been | ||
| // defined. | ||
| #[should_panic] |
There was a problem hiding this comment.
Minor: Maybe also add this to #1841?
There was a problem hiding this comment.
Done!
I just noticed a bug here: these functions should all use Testnet, because it will have an activation height first.
(Ideally they should use both networks, but that's a larger change.)
There was a problem hiding this comment.
Bug fixed in 09b815c, also I updated the ticket, and added "any other should_panic" tests.
We've marked these tests as should_panic until there is a NU5 activation height. But Testnet will have an activation height first, so we should prefer it in the tests. (Or use both networks.)
|
This is ready for another review. But since all the changes were optional, I can also merge once CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #2401, a
transaction::Verifierbug introduced by PR #2382.This bug stops Zebra syncing after the mandatory Canopy checkpoint, as soon as the
transaction::Verifierstarts being used.Specifications
Unfortunately, the Zcash specification doesn't cover all the validation rules for coinbase inputs and outputs.
Solution
Review
@jvff can review this PR, it's a high priority, because it stops syncing. (And makes other code hard to test.)
Reviewer Checklist
Follow Up Work
We'll do shielded coinbase tests as part of the shielded coinbase ticket.