Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NU5 Tracking Epic #1841

Closed
13 tasks done
yaahc opened this issue Mar 2, 2021 · 9 comments
Closed
13 tasks done

NU5 Tracking Epic #1841

yaahc opened this issue Mar 2, 2021 · 9 comments
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped NU-5 Network Upgrade: NU5 specific tasks S-blocked Status: Blocked on other tasks

Comments

@yaahc
Copy link
Contributor

yaahc commented Mar 2, 2021

Motivation

In #1823 we added initial support for NU5 to zebra. Right now this support is incomplete since we have not finished drafting the zip for the next network upgrade, so we don't yet know things like the activation height or the precise consensus rule changes that will be made in NU5.
-Track all NU5 epics

Solution

Once we've finalized the proposal for NU5 we need to follow up on the initial support to replace various todo's in the code and replace them with the specified logic.

Note: NU5 also contains other ZIPs, see #1598 and ZIP-252.

Testnet: ZIP-252

Zebra:

DNS Seeders:

The DNS seeders don't check the activation height. So it's ok to increase the maximum version a few weeks early.

Mainnet: ZIP-252

Zebra mainnet:

Zebra testnet:

DNS Seeders:

  • Increment the maximum network protocol version accepted by the foundation's DNS seeders to 170_017
  • Re-deploy the foundation's DNS seeders
    • Check that the mainnet seeder is returning new peers
    • Check that the testnet seeder continues to return new peers
@yaahc yaahc added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Mar 2, 2021
@teor2345 teor2345 added A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code NU-5 Network Upgrade: NU5 specific tasks P-Medium labels Mar 2, 2021
@teor2345
Copy link
Contributor

teor2345 commented Mar 2, 2021

@yaahc I sorted the tasks by ZIP and added ticket numbers for the tickets that have already been opened.

There's a bit of overlap between this ticket and the epic ticket #1598, how do you want to resolve that?

Maybe we should make this ticket about the generic network upgrade process (ZIP-252), and move all the other tasks to #1598?

@yaahc
Copy link
Contributor Author

yaahc commented Mar 2, 2021

There's a bit of overlap between this ticket and the epic ticket #1598, how do you want to resolve that?

Maybe we should make this ticket about the generic network upgrade process (ZIP-252), and move all the other tasks to #1598?

Not sure, I think I'll leave that up to @mpguerra to decide how to track everything.

@mpguerra mpguerra added the Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped label Mar 3, 2021
@teor2345 teor2345 changed the title Fully implement NU5 network upgrade logic in zebra Implement Zebra-specific NU5 network upgrade logic Mar 4, 2021
@mpguerra
Copy link
Contributor

mpguerra commented Mar 9, 2021

Removed

ZIP-244:

from issue description and moved to #1874 where this work will be done.

Tracking for ZIP-244 is done in #1854

@mpguerra mpguerra changed the title Implement Zebra-specific NU5 network upgrade logic ZIP-252: Implement Zebra-specific NU5 network upgrade logic Mar 9, 2021
@mpguerra mpguerra removed the Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped label Mar 9, 2021
@mpguerra
Copy link
Contributor

mpguerra commented Mar 9, 2021

Thinking about it some more, I've made this into ZIP 252 as suggested and added it to #1854 ZIP tracking issue

@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Mar 10, 2021
@mpguerra mpguerra added this to the 2021 Sprint 12 milestone May 6, 2021
@teor2345
Copy link
Contributor

teor2345 commented Jun 7, 2021

We haven't chosen the testnet activation height yet, moving this ticket to sprint 13.

@teor2345 teor2345 changed the title ZIP-252: Implement Zebra-specific NU5 network upgrade logic ZIP-252: Add NU5 network upgrade activation heights to Zebra Jun 7, 2021
@teor2345 teor2345 changed the title ZIP-252: Add NU5 network upgrade activation heights to Zebra ZIP-252: Update Zebra and DNS Seeders with NU5 activation heights Jun 13, 2021
@jvff jvff mentioned this issue Jun 22, 2021
3 tasks
@teor2345 teor2345 changed the title ZIP-252: Update Zebra and DNS Seeders with NU5 activation heights ZIP-252: Update Zebra and DNS Seeders with NU5 heights and protocol versions Jun 25, 2021
@mpguerra mpguerra added the S-blocked Status: Blocked on other tasks label Jul 13, 2021
@mpguerra
Copy link
Contributor

Removing from Sprint 19 as this is now more of a tracking ticket containing mainnet activation tasks also

@mpguerra mpguerra added the Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped label Sep 30, 2021
@teor2345 teor2345 changed the title ZIP-252: Update Zebra and DNS Seeders with NU5 heights and protocol versions ZIP-252: Update Zebra and DNS Seeders for NU5 mainnet activation Nov 8, 2021
@teor2345 teor2345 changed the title ZIP-252: Update Zebra and DNS Seeders for NU5 mainnet activation ZIP-252: Update Zebra for NU5 mainnet activation Nov 22, 2021
@teor2345
Copy link
Contributor

We updated the DNS seeder network protocol versions as part of #2882.

@ftm1000 ftm1000 changed the title ZIP-252: Update Zebra for NU5 mainnet activation NU% Tracing Epic Mar 31, 2022
@ftm1000 ftm1000 changed the title NU% Tracing Epic NU5 Tracing Epic Mar 31, 2022
@ftm1000 ftm1000 changed the title NU5 Tracing Epic NU5 Tracking Epic Mar 31, 2022
@teor2345
Copy link
Contributor

teor2345 commented Jun 2, 2022

NU5 activated 3 days ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped NU-5 Network Upgrade: NU5 specific tasks S-blocked Status: Blocked on other tasks
Projects
None yet
Development

No branches or pull requests

3 participants