Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft PR template for release checklist #1717

Merged
merged 6 commits into from
Feb 10, 2021

Conversation

dconnolly
Copy link
Contributor

Motivation

There are some things we want to make sure we do for a release, which usually involves bumping versions in a commit, which is then tagged/triggers other actions.

Solution

This is a PR template that provides the checks we want to do as part of a version bump/release PR.

Review

@teor2345 @yaahc @oxarbitrage @mpguerra

Related Issues

#1063

Follow Up Work

Should probably mention this in the release RFC

@dconnolly dconnolly requested a review from teor2345 February 9, 2021 16:56
@dconnolly dconnolly marked this pull request as ready for review February 9, 2021 21:19
@dconnolly dconnolly added the A-infrastructure Area: Infrastructure changes label Feb 9, 2021
teor2345 and others added 2 commits February 9, 2021 17:19
We want to be very clear about the process now,
so we get consistency, and so other developers
can follow it.

Eventually, these details should move to the
developer book.
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this overall, I also made a few minor suggestions

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge!

@teor2345 teor2345 merged commit d93804e into main Feb 10, 2021
@teor2345 teor2345 deleted the release-checklist-pr-template branch February 10, 2021 00:57
@dconnolly dconnolly added this to the 2021 Sprint 3 milestone Feb 10, 2021
dconnolly added a commit that referenced this pull request Feb 11, 2021
* Add draft PR template for release checklist

* Add some notes about keepachangelog categories

* Add excessive detail to the release checklist

We want to be very clear about the process now,
so we get consistency, and so other developers
can follow it.

Eventually, these details should move to the
developer book.

* Add links for Release Drafter and the GitHub Releases location

Co-authored-by: teor <[email protected]>
@teor2345 teor2345 mentioned this pull request Feb 23, 2021
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infrastructure Area: Infrastructure changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants