-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add draft PR template for release checklist #1717
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to be very clear about the process now, so we get consistency, and so other developers can follow it. Eventually, these details should move to the developer book.
teor2345
reviewed
Feb 10, 2021
teor2345
reviewed
Feb 10, 2021
teor2345
reviewed
Feb 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this overall, I also made a few minor suggestions
Co-authored-by: teor <[email protected]>
Co-authored-by: teor <[email protected]>
teor2345
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge!
dconnolly
added a commit
that referenced
this pull request
Feb 11, 2021
* Add draft PR template for release checklist * Add some notes about keepachangelog categories * Add excessive detail to the release checklist We want to be very clear about the process now, so we get consistency, and so other developers can follow it. Eventually, these details should move to the developer book. * Add links for Release Drafter and the GitHub Releases location Co-authored-by: teor <[email protected]>
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are some things we want to make sure we do for a release, which usually involves bumping versions in a commit, which is then tagged/triggers other actions.
Solution
This is a PR template that provides the checks we want to do as part of a version bump/release PR.
Review
@teor2345 @yaahc @oxarbitrage @mpguerra
Related Issues
#1063
Follow Up Work
Should probably mention this in the release RFC