-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump versions for zebrad 1.0.0-alpha.2 #1716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked every instance of the version string in zebra:
- zebra*
Cargo.toml
s - tower-*
Cargo.toml
s README.md
zebrad
app version- network protocol user agent
- we've never updated the
tower-fallback
version, and there was an interface change in July 2020, so let's update it to version0.2.0
-
zebra-script
depends onzebra-chain
, which has changed, sozebra-script
needs an increment to1.0.0-alpha.3
-
zebra-rpc
andzebra-client
haven't changed, and have no dependencies, so they don't need an increment -
zebra-utils
depends on crates that have changed, so it needs an increment - all other crates have been changed and need an increment
- the app and network versions are incremented every time the
zebrad
crate is incremented - the
README.md
version is incremented for every tag
This is a complex series of checks, let's turn it into a PR template or another kind of checklist?
I'm happy to do a quick edit to create the checklist, I just need to know where to put it. What do you think is best @dconnolly?
(Eventually we should automate version increments, but that's not scheduled for this sprint, so turning this list into a checklist will help with the version updates for the next few sprints/tags.)
Edit: I also want to add instructions like "look at the zebra GitHub code page, check to see which crates have new commits since the last version update, then deal with dependencies"
A PR template sounds like the correct option yeah, even when we automate a lot of things, there will be a human action that will either trigger the automation or whatever, and it can continue to evolve from PRs using that template. 👍 EDIT: #1717 |
d4024cb
to
7f65c8e
Compare
Including tower-batch bump to 0.2.0, tower-fallback to 0.2.0, zebra-script to 1.0.0-alpha.3
7f65c8e
to
e261f61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @dconnolly . Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good now
Motivation
Release!
Solution
Bumps versions to v1.0.0-alpha.2 for relevant Zebra crates and tower-batch to 0.2.0, which will be tagged by https://github.com/ZcashFoundation/zebra/releases/tag/untagged-bd38ff7699647bcf8339
Review
Anyone from Zebra team