Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions for zebrad 1.0.0-alpha.2 #1716

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Bump versions for zebrad 1.0.0-alpha.2 #1716

merged 1 commit into from
Feb 9, 2021

Conversation

dconnolly
Copy link
Contributor

Motivation

Release!

Solution

Bumps versions to v1.0.0-alpha.2 for relevant Zebra crates and tower-batch to 0.2.0, which will be tagged by https://github.com/ZcashFoundation/zebra/releases/tag/untagged-bd38ff7699647bcf8339

Review

Anyone from Zebra team

@dconnolly dconnolly requested a review from a team February 9, 2021 02:40
mpguerra
mpguerra previously approved these changes Feb 9, 2021
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked every instance of the version string in zebra:

  • zebra* Cargo.tomls
  • tower-* Cargo.tomls
  • README.md
  • zebrad app version
  • network protocol user agent
  • we've never updated the tower-fallback version, and there was an interface change in July 2020, so let's update it to version 0.2.0
  • zebra-script depends on zebra-chain, which has changed, so zebra-script needs an increment to 1.0.0-alpha.3
  • zebra-rpc and zebra-client haven't changed, and have no dependencies, so they don't need an increment
  • zebra-utils depends on crates that have changed, so it needs an increment
  • all other crates have been changed and need an increment
  • the app and network versions are incremented every time the zebrad crate is incremented
  • the README.md version is incremented for every tag

This is a complex series of checks, let's turn it into a PR template or another kind of checklist?

I'm happy to do a quick edit to create the checklist, I just need to know where to put it. What do you think is best @dconnolly?

(Eventually we should automate version increments, but that's not scheduled for this sprint, so turning this list into a checklist will help with the version updates for the next few sprints/tags.)

Edit: I also want to add instructions like "look at the zebra GitHub code page, check to see which crates have new commits since the last version update, then deal with dependencies"

@dconnolly
Copy link
Contributor Author

dconnolly commented Feb 9, 2021

I've checked every instance of the version string in zebra:

  • zebra* Cargo.tomls

  • tower-* Cargo.tomls

  • README.md

  • zebrad app version

  • network protocol user agent

  • we've never updated the tower-fallback version, and there was an interface change in July 2020, so let's update it to version 0.2.0

  • zebra-script depends on zebra-chain, which has changed, so zebra-script needs an increment to 1.0.0-alpha.3

  • zebra-rpc and zebra-client haven't changed, and have no dependencies, so they don't need an increment

  • zebra-utils depends on crates that have changed, so it needs an increment

  • all other crates have been changed and need an increment

  • the app and network versions are incremented every time the zebrad crate is incremented

  • the README.md version is incremented for every tag

This is a complex series of checks, let's turn it into a PR template or another kind of checklist?

I'm happy to do a quick edit to create the checklist, I just need to know where to put it. What do you think is best @dconnolly?

(Eventually we should automate version increments, but that's not scheduled for this sprint, so turning this list into a checklist will help with the version updates for the next few sprints/tags.)

Edit: I also want to add instructions like "look at the zebra GitHub code page, check to see which crates have new commits since the last version update, then deal with dependencies"

A PR template sounds like the correct option yeah, even when we automate a lot of things, there will be a human action that will either trigger the automation or whatever, and it can continue to evolve from PRs using that template. 👍

EDIT: #1717

Including tower-batch bump to 0.2.0, tower-fallback to 0.2.0, zebra-script to 1.0.0-alpha.3
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @dconnolly . Thanks.

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good now

@dconnolly dconnolly merged commit 0c5daa8 into main Feb 9, 2021
@dconnolly dconnolly deleted the bump-version branch February 9, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants