-
Notifications
You must be signed in to change notification settings - Fork 107
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
We can't remove `actions/checkout` nor set `create_credentials_file` to `false` as next steps won't be able to authenticate to GCP. We can surely remove `actions/checkout` and leave `create_credentials_file` as `true`, but this will raise a warning on each step, and there's no benefit of doing so.
- Loading branch information
1 parent
93414eb
commit 99ef632
Showing
1 changed file
with
0 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -100,8 +100,6 @@ jobs: | |
| contents: 'read' | ||
| id-token: 'write' | ||
| steps: | ||
| # TODO: can we delete this step and set create_credentials_file to false in Google Cloud? | ||
| # Or will that break the slug-action variables we use to find the instance? | ||
| - uses: actions/[email protected] | ||
| with: | ||
| persist-credentials: false | ||
|
|
@@ -169,8 +167,6 @@ jobs: | |
| contents: 'read' | ||
| id-token: 'write' | ||
| steps: | ||
| # TODO: can we delete this step and set create_credentials_file to false in Google Cloud? | ||
| # Or will that break the slug-action variables we use to find the instance? | ||
| - uses: actions/[email protected] | ||
| with: | ||
| persist-credentials: false | ||
|
|
@@ -345,8 +341,6 @@ jobs: | |
| contents: 'read' | ||
| id-token: 'write' | ||
| steps: | ||
| # TODO: can we delete this step and set create_credentials_file to false in Google Cloud? | ||
| # Or will that break the slug-action variables we use to find the instance? | ||
| - uses: actions/[email protected] | ||
| with: | ||
| persist-credentials: false | ||
|
|
@@ -472,8 +466,6 @@ jobs: | |
| contents: 'read' | ||
| id-token: 'write' | ||
| steps: | ||
| # TODO: can we delete this step and set create_credentials_file to false in Google Cloud? | ||
| # Or will that break the slug-action variables we use to find the instance? | ||
| - uses: actions/[email protected] | ||
| with: | ||
| persist-credentials: false | ||
|
|
@@ -533,8 +525,6 @@ jobs: | |
| contents: 'read' | ||
| id-token: 'write' | ||
| steps: | ||
| # TODO: can we delete this step and set create_credentials_file to false in Google Cloud? | ||
| # Or will that break the slug-action variables we use to find the instance? | ||
| - uses: actions/[email protected] | ||
| with: | ||
| persist-credentials: false | ||
|
|
@@ -589,8 +579,6 @@ jobs: | |
| contents: 'read' | ||
| id-token: 'write' | ||
| steps: | ||
| # TODO: can we delete this step and set create_credentials_file to false in Google Cloud? | ||
| # Or will that break the slug-action variables we use to find the instance? | ||
| - uses: actions/[email protected] | ||
| with: | ||
| persist-credentials: false | ||
|
|
@@ -648,8 +636,6 @@ jobs: | |
| contents: 'read' | ||
| id-token: 'write' | ||
| steps: | ||
| # TODO: can we delete this step and set create_credentials_file to false in Google Cloud? | ||
| # Or will that break the slug-action variables we use to find the instance? | ||
| - uses: actions/[email protected] | ||
| with: | ||
| persist-credentials: false | ||
|
|
@@ -796,8 +782,6 @@ jobs: | |
| contents: 'read' | ||
| id-token: 'write' | ||
| steps: | ||
| # TODO: can we delete this step and set create_credentials_file to false in Google Cloud? | ||
| # Or will that break the slug-action variables we use to find the instance? | ||
| - uses: actions/[email protected] | ||
| with: | ||
| persist-credentials: false | ||
|
|
||