Skip to content

Commit

Permalink
fix(ci): docker wait not finding container
Browse files Browse the repository at this point in the history
We had this issue before, I can't recall if this was a parsing error between GitHub Actions and gcloud `--command` parsing, but we had to change this into two pieces.

This implementation keeps it how we did it before https://github.com/ZcashFoundation/zebra/blob/9b9578c99975952a291006dde8d2828fd3e97799/.github/workflows/test.yml#L235-L243
  • Loading branch information
gustavovalverde committed Jun 29, 2022
1 parent 6a86516 commit 93414eb
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/deploy-gcp-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -680,15 +680,15 @@ jobs:
# `docker wait` can also wait for multiple containers, but we only ever wait for a single container.
- name: Result of ${{ inputs.test_id }} test
run: |
EXIT_CODE=$(\
gcloud compute ssh \
${{ inputs.test_id }}-${{ env.GITHUB_REF_SLUG_URL }}-${{ env.GITHUB_SHA_SHORT }} \
--zone ${{ env.ZONE }} \
--quiet \
--ssh-flag="-o ServerAliveInterval=5" \
--command \
"\
exit $(docker wait ${{ inputs.test_id }}) \
"
--command="docker wait ${{ inputs.test_id }}")
exit ${EXIT_CODE}
# create a state image from the instance's state disk, if requested by the caller
Expand Down

0 comments on commit 93414eb

Please sign in to comment.