-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-enable for certain sites #15
Comments
I've thought about some similar features using a couple different means but not exactly in this way. This way seems achievable and limited in scope, which is good. I can imagine it possibly be annoying, but it's worth exploring/testing for sure. Some questions I have regarding user expectations of the feature (I have my own answers to this but I'm curious what you think for each):
|
I implemented this feature in 94144f0 / 1.0.8 but have done minimal testing thus far. You can optionally enable it on the Options page under "Auto-run domain list". To do so, just include
Edit: Just Read now uses regex to parse the given list. This allows more freedom to specify specific types of pages while keeping the error rate low. For more information see the comment below. Answering my own questions from the post above for completeness (for how it currently works):
|
Fantastic follow-through, thanks very much. I'd meant to write up some responses for you but got caught up in work. Just got the notification of your update this morning... sorry for leaving you hanging. I haven't had a chance to try out your implementation yet but the logic you describe seems reasonable. Shame about the visual flash before |
Notice the change in functionality since posting: as of version 1.0.9 it will search the given URL vs the new page's URL to determine whether or not it should auto-run Just Read. Let me know if I broke something, haha. Thanks for suggesting the feature! |
FYI I'm loving this feature, haha |
I just added another related feature in version 1.0.11 where users can open an article in Just Read form by right clicking a link to the article then clicking "View the linked page using Just Read", which will load the link in a new tab and automatically run Just Read on it (without having to add it to the domain list or navigate to the page and manually open Just Read). I looked into creating a keyboard shortcut for this, like Ctrl + Alt + Left-click on a link, but couldn't figure out how to properly get it working. |
In order to give more control, I switched this over to use JavaScript's
or any other valid Regex expression. You can play around with string and expression matching here. See MDN for more information. I am using the ignore case Side note: This list is checked automatically (the save button doesn't have to be clicked). EditAs of Just Read version 5.2.0, you can also append a
would delay Just Read's autostart by 5 seconds for URLs that contain that string. |
This is brilliant and the sole reason I installed the extension. Personally I want to use Just Read everytime I read an article. At which point the system would bog down, because of too much regex parsing? |
@ysamjo I'm glad you like it! So far the answer is no, there isn't a crowdsourced list of article-type websites. But you're free to start one! If you do, make sure that the regex selects only article-type pages of given websites as much as possible, meaning probably not the home page of many websites but preferably only the article pages. I realize that isn't always possible to do. As for bogging down your browser or Just Read, the only thing it could do it increase the amount of time it takes for Just Read to start. JavaScript is pretty fast, so the list would have to be long for it to make any noticeable affect. With all of that being said, the reason why I don't attempt to have a running list is because it's likely to be error prone, especially given time, and many people are okay with reading articles on some webpages because the built in styling isn't horrid, whereas on specific other sites the built in styling is so bad that they really need to use Just Read. |
Can you help me understand this feature a bit? How can I do this? |
@gouravkr It checks using regex format. I'm not very good at regex, so this could likely be improved, but this should work for you:
It checks that the start is |
I love selected text and deletion mode features. But can you have some kind of undo for deletion? sometimes I accidentally delete the wrong part or even the whole main text, then I have to do the deletion from the beginning. |
@sinhthanh Yes, that's a good suggestion. I'd likely implement undo for title/author changes as well - a more full undo functionality. I made a new issue requesting it - #156 |
@ZachSaucier I experienced that a lot of blogs are structuring their URLs as follows: http(s)://name.tld/year/month/day/ID/articlename Can you tell me the Regex to single out every URL that has a /20* behind the TLD? |
@ysamjo A (probably crappy) way to do this would be to use |
Just Read allows for sites to automatically be added to the auto-run list and there is an optional context menu entry to add the current page to the auto-run list. See this post for more. |
Great extension! I'd love the ability to auto-activate Just Read on certain sites. A user-configurable list of domains in the options screen would probably be sufficient. Have you thought about implementing such a feature?
The text was updated successfully, but these errors were encountered: