Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an "undo" functionality for deletion mode and editing meta information #156

Closed
ZachSaucier opened this issue May 15, 2018 · 8 comments

Comments

@ZachSaucier
Copy link
Owner

It would be useful to have a "CTRL + Z" undo type of functionality when an element is accidentally clicked in deletion mode or edited incorrectly so that the whole page/selection would not have to be re-selected.

@ZachSaucier
Copy link
Owner Author

Undo now works as of JR version 1.2.1 and in all versions of Just Read Premium.

@pato7
Copy link

pato7 commented Nov 5, 2018

Would it be possible to add a dedicated icon for this action as well?

@ZachSaucier
Copy link
Owner Author

It's possible, but what's your reasoning behind wanting it? I think "Ctrl + Z" to undo is a well known action and adding a specific button for it would go unused the majority of the time, plus it'd make JR more cluttered.

@pato7
Copy link

pato7 commented Nov 5, 2018

  1. I recommend this extension to many users, many of which are not advanced users, and they will not remember the shortcut.
  2. For some languages users may switch between QWERTY and QWERTZ keyboard.
  3. Everything could be doable by mouse only - that is the reason why Print icon was added (even there is known shortcut CTRL + P), right?
  4. I wouldn't even know "Undo" is possible if I haven't read this issues list.

@ZachSaucier
Copy link
Owner Author

I think that's reasonable and I can allow it to be disabled through the Options page. I'll implement it when I get some time. Thanks for suggesting it!

@ZachSaucier
Copy link
Owner Author

ZachSaucier commented Nov 17, 2018

The change including the undo icon should be live now! You should have access as soon as your JR version updates to the latest version.

@pato7
Copy link

pato7 commented Nov 17, 2018

When printed, undo icon remains visible.

@ZachSaucier
Copy link
Owner Author

I take that back. Yes, this is a but because of a missing !important in the free version. Updating now. Thanks for catching it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants