[Alerting] Fixed bug with no possibility to edit the index name after…

… adding (elastic#64033) * Fixed bug with no possibility to edit the index name after adding * fixed test * fixed test * fixed selector * Move the testing to unit tests
YulNaumenko · May 14, 2020 · e6efe39 · e6efe39
1 parent 3dba1a0
commit e6efe39
Show file tree

Hide file tree

Showing 2 changed files with 67 additions and 3 deletions.
diff --git a/.../triggers_actions_ui/public/application/components/builtin_action_types/es_index.test.tsx b/.../triggers_actions_ui/public/application/components/builtin_action_types/es_index.test.tsx
@@ -4,12 +4,19 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 import React, { FunctionComponent } from 'react';
-import { mountWithIntl } from 'test_utils/enzyme_helpers';
+import { mountWithIntl, nextTick } from 'test_utils/enzyme_helpers';
+import { act } from 'react-dom/test-utils';
 import { TypeRegistry } from '../../type_registry';
 import { registerBuiltInActionTypes } from './index';
 import { ActionTypeModel, ActionParamsProps } from '../../../types';
 import { IndexActionParams, EsIndexActionConnector } from './types';
 import { coreMock } from '../../../../../../../src/core/public/mocks';
+jest.mock('../../../common/index_controls', () => ({
+  firstFieldOption: jest.fn(),
+  getFields: jest.fn(),
+  getIndexOptions: jest.fn(),
+  getIndexPatterns: jest.fn(),
+}));
 
 const ACTION_TYPE_ID = '.index';
 let actionTypeModel: ActionTypeModel;
@@ -91,13 +98,40 @@ describe('action params validation', () => {
 });
 
 describe('IndexActionConnectorFields renders', () => {
-  test('all connector fields is rendered', () => {
+  test('all connector fields is rendered', async () => {
     const mocks = coreMock.createSetup();
 
     expect(actionTypeModel.actionConnectorFields).not.toBeNull();
     if (!actionTypeModel.actionConnectorFields) {
       return;
     }
+
+    const { getIndexPatterns } = jest.requireMock('../../../common/index_controls');
+    getIndexPatterns.mockResolvedValueOnce([
+      {
+        id: 'indexPattern1',
+        attributes: {
+          title: 'indexPattern1',
+        },
+      },
+      {
+        id: 'indexPattern2',
+        attributes: {
+          title: 'indexPattern2',
+        },
+      },
+    ]);
+    const { getFields } = jest.requireMock('../../../common/index_controls');
+    getFields.mockResolvedValueOnce([
+      {
+        type: 'date',
+        name: 'test1',
+      },
+      {
+        type: 'text',
+        name: 'test2',
+      },
+    ]);
     const ConnectorFields = actionTypeModel.actionConnectorFields;
     const actionConnector = {
       secrets: {},
@@ -119,8 +153,38 @@ describe('IndexActionConnectorFields renders', () => {
         http={mocks.http}
       />
     );
+
+    await act(async () => {
+      await nextTick();
+      wrapper.update();
+    });
+
     expect(wrapper.find('[data-test-subj="connectorIndexesComboBox"]').length > 0).toBeTruthy();
     expect(wrapper.find('[data-test-subj="indexRefreshCheckbox"]').length > 0).toBeTruthy();
+
+    const indexSearchBoxValue = wrapper.find('[data-test-subj="comboBoxSearchInput"]');
+    expect(indexSearchBoxValue.first().props().value).toEqual('');
+
+    const indexComboBox = wrapper.find('#indexConnectorSelectSearchBox');
+    indexComboBox.first().simulate('click');
+    const event = { target: { value: 'indexPattern1' } };
+    indexComboBox
+      .find('input')
+      .first()
+      .simulate('change', event);
+
+    const indexSearchBoxValueBeforeEnterData = wrapper.find(
+      '[data-test-subj="comboBoxSearchInput"]'
+    );
+    expect(indexSearchBoxValueBeforeEnterData.first().props().value).toEqual('indexPattern1');
+
+    const indexComboBoxClear = wrapper.find('[data-test-subj="comboBoxClearButton"]');
+    indexComboBoxClear.first().simulate('click');
+
+    const indexSearchBoxValueAfterEnterData = wrapper.find(
+      '[data-test-subj="comboBoxSearchInput"]'
+    );
+    expect(indexSearchBoxValueAfterEnterData.first().props().value).toEqual('indexPattern1');
   });
 });
 

diff --git a/...ugins/triggers_actions_ui/public/application/components/builtin_action_types/es_index.tsx b/...ugins/triggers_actions_ui/public/application/components/builtin_action_types/es_index.tsx
@@ -151,7 +151,7 @@ const IndexActionConnectorFields: React.FunctionComponent<ActionConnectorFieldsP
               : []
           }
           onChange={async (selected: EuiComboBoxOptionOption[]) => {
-            editActionConfig('index', selected[0].value);
+            editActionConfig('index', selected.length > 0 ? selected[0].value : '');
             const indices = selected.map(s => s.value as string);
 
             // reset time field and expression fields if indices are deleted