Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make button features that aren't enabled have the placement select disabled #504

Closed
VampireChicken12 opened this issue May 30, 2024 · 1 comment
Assignees
Labels
complete Use this label for a feature/bug issue that is complete but not released yet enhancement New feature or request released

Comments

@VampireChicken12
Copy link
Member

This will improve the user experience by visually showing the placement isn't used because the feature is disabled.

@VampireChicken12
Copy link
Member Author

The disabled button placement select will look something like this
NVIDIA_GeForce_Overlay_DT_IU7dvIRK66

@VampireChicken12 VampireChicken12 self-assigned this Jun 2, 2024
@VampireChicken12 VampireChicken12 moved this from Todo to In Progress in YouTube Enhancer Jun 2, 2024
@VampireChicken12 VampireChicken12 moved this from In Progress to Done in YouTube Enhancer Jun 2, 2024
@VampireChicken12 VampireChicken12 added the complete Use this label for a feature/bug issue that is complete but not released yet label Jun 2, 2024
@VampireChicken12 VampireChicken12 moved this from Done to In Progress in YouTube Enhancer Jun 3, 2024
github-actions bot pushed a commit that referenced this issue Jun 29, 2024
# [1.26.0](v1.25.0...v1.26.0) (2024-06-29)

### Bug Fixes

* broken features ([742be90](742be90))
* Button placement change causing multi buttons to stop working. ([caed598](caed598))
* color pickers opening when they shouldn't ([b53edd7](b53edd7))
* continue when old and new placement is the same ([dd9b089](dd9b089))
* deep dark author/co author title ([a3503d5](a3503d5))
* features with multi buttons placement issue ([50014cb](50014cb))
* object type not being handled properly ([b34b86e](b34b86e))
* old button placement not being removed ([b995911](b995911))
* playback speed button order issue ([186c4c5](186c4c5))

### Features

* **automatic quality:** Fallback strategy [#461](#461) ([c621580](c621580))
* Disable button's placement select when button isn't enabled [#504](#504) ([916b39c](916b39c))
* forward rewind buttons [#486](#486) ([1a80122](1a80122))
* Hide end screen cards button [#484](#484) ([5e047c5](5e047c5))
* hide paid promotion banner [#519](#519) ([5356f8d](5356f8d))
* Setting search bar ([013ce19](013ce19))

## Release Artifacts
| File Name | SHA-256 Hash |
| :--- | :---: |
| youtube-enhancer-v1.26.0-Chrome.zip | a97eca36b647d176c303bd30096509052695a70152c0f56550a319762e9827a3 |
| youtube-enhancer-v1.26.0-Chromium.zip | a97eca36b647d176c303bd30096509052695a70152c0f56550a319762e9827a3 |
| youtube-enhancer-v1.26.0-Edge.zip | a97eca36b647d176c303bd30096509052695a70152c0f56550a319762e9827a3 |
| youtube-enhancer-v1.26.0-Firefox.zip | 0eee8b8088e4fdbe87b997d252851e4b6918f20180c83574f3405ce2126955fb |
@VampireChicken12 VampireChicken12 moved this from In Progress to Done in YouTube Enhancer Jun 29, 2024
@VampireChicken12 VampireChicken12 closed this as completed by moving to Done in YouTube Enhancer Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complete Use this label for a feature/bug issue that is complete but not released yet enhancement New feature or request released
Projects
Status: Done
Development

No branches or pull requests

1 participant