Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Disable End Screen Cards option button #484

Closed
slrgt opened this issue May 15, 2024 · 14 comments
Closed

[Feature Request] Disable End Screen Cards option button #484

slrgt opened this issue May 15, 2024 · 14 comments
Assignees
@VampireChicken12
Labels
complete Use this label for a feature/bug issue that is complete but not released yet enhancement New feature or request released

Comments

@slrgt
Copy link

slrgt commented May 15, 2024 •
edited
Loading

Can the End Screen Cards option also be available as a button that can be clicked on\off similar to the speed and screenshot buttons under the player? Would help for the videos that don't have an outro and for the videos that sometimes have useful screen cards

Originally posted by @slrgt in #373 (comment)

P.S. The decrease speed button is still to the right of the Increase button which makes it a bit confusing hehe
@slrgt slrgt changed the title Can the End Screen Cards option also be available as a button that can be clicked on\off similar to the speed and screenshot buttons under the player? Would help for the videos that don't have an outro and for the videos that sometimes have useful screen cards Disable End Screen Cards option button May 15, 2024
@VampireChicken12
Copy link
Member

Thanks @slrgt the speed button order will be fixed later.

@VampireChicken12 VampireChicken12 self-assigned this May 16, 2024
@VampireChicken12 VampireChicken12 added the enhancement New feature or request label May 16, 2024
@VampireChicken12 VampireChicken12 moved this to In Progress in YouTube Enhancer May 16, 2024
@VampireChicken12
Copy link
Member

@slrgt I started working on the feature it won't be released until some more features or bug fixes are done. You can always build from dev branch.

@VampireChicken12
Copy link
Member

@slrgt the feature is almost done, I just need to finish up a thing or two.

@VampireChicken12
Copy link
Member

@slrgt Without me explaining what the different icons mean, do you understand what the button is doing when clicked

(75)Ranking_of_Kings-Opening_2__Naked_Hero-_Yo_UotPm7ZcQb
(75)Ranking_of_Kings-Opening_2__Naked_Hero-_Yo_qS6fN16tcj

@slrgt
Copy link
Author

slrgt commented May 16, 2024 via email

@VampireChicken12
Copy link
Member

Yes and they look good! Will we be able to put them under the player with the speed buttons?
…
On Thu, May 16, 2024 at 6:56 PM, Nathan @.(mailto:On Thu, May 16, 2024 at 6:56 PM, Nathan < wrote: @.(https://github.com/slrgt) Without me explaining what the different icons mean, do you understand what the button is doing when clicked 75.Ranking_of_Kings-Opening_2__Naked_Hero-_Yo_UotPm7ZcQb.png (view on web) 75.Ranking_of_Kings-Opening_2__Naked_Hero-_Yo_qS6fN16tcj.png (view on web) — Reply to this email directly, [view it on GitHub](#484 (comment)), or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

yes, any buttons added going forward can be placed in the following positions: below player, left controls, right controls, feature menu

@slrgt
Copy link
Author

slrgt commented May 16, 2024 via email

@VampireChicken12
Copy link
Member

@slrgt I have coded the hide end screen cards button to integrate with the hide end screen cards setting if the cards are hidden by it the button will show them if not hidden it will hide them, also when that setting changes it updates the button.

@VampireChicken12
Copy link
Member

@slrgt I ran into an issue when the hide end screen button is in the feature menu. Once I fix that issue I will publish the branch and merge it to dev

@VampireChicken12 VampireChicken12 mentioned this issue May 18, 2024
Open
VampireChicken12 added a commit that referenced this issue May 19, 2024
@VampireChicken12
feat: Hide end screen cards button #484
5e047c5
@VampireChicken12
Copy link
Member

@slrgt the feature has been merged into dev. It won't be released for a bit. I want to get a few more features and bug fixes done if possible.

@VampireChicken12
Copy link
Member

VampireChicken12 commented May 19, 2024 •
edited
Loading

File Name SHA-256 Hash
youtube-enhancer-v1.25.0-Chrome.zip 0f29d854c7c455014b23aee65b728f6954f4d907c6b1db536b12c087338f9f78
youtube-enhancer-v1.25.0-Edge.zip 0f29d854c7c455014b23aee65b728f6954f4d907c6b1db536b12c087338f9f78
youtube-enhancer-v1.25.0-Firefox.zip b742640aa1f120ff8915430316c47c3f93a7c187a3cef1bad79dab5e3bc2364f

@slrgt I built the extension and attached Chrome, Edge, Firefox zips here.

The version says 1.25.0 but it does have the new feature I just didn't update package.json

@slrgt
Copy link
Author

slrgt commented May 19, 2024 via email

@VampireChicken12
Copy link
Member

🤩 thanks!
…
On Sun, May 19, 2024 at 12:38 AM, Nathan @.(mailto:On Sun, May 19, 2024 at 12:38 AM, Nathan < wrote: File Name SHA-256 Hash youtube-enhancer-v1.25.0-Chrome.zip 0f29d854c7c455014b23aee65b728f6954f4d907c6b1db536b12c087338f9f78 youtube-enhancer-v1.25.0-Edge.zip 0f29d854c7c455014b23aee65b728f6954f4d907c6b1db536b12c087338f9f78 youtube-enhancer-v1.25.0-Firefox.zip b742640aa1f120ff8915430316c47c3f93a7c187a3cef1bad79dab5e3bc2364f youtube-enhancer-v1.25.0-Chrome.zip youtube-enhancer-v1.25.0-Edge.zip youtube-enhancer-v1.25.0-Firefox.zip @.(https://github.com/slrgt) I built the extension and attached Chrome, Edge, Firefox zips here. — Reply to this email directly, [view it on GitHub](#484 (comment)), or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

no problem

@VampireChicken12 VampireChicken12 added the complete Use this label for a feature/bug issue that is complete but not released yet label May 19, 2024
@VampireChicken12 VampireChicken12 moved this from In Progress to Done in YouTube Enhancer May 19, 2024
@VampireChicken12 VampireChicken12 changed the title Disable End Screen Cards option button [Feature Request] Disable End Screen Cards option button May 19, 2024
github-actions bot pushed a commit that referenced this issue Jun 29, 2024
@semantic-release-bot
chore(release): 1.26.0 [skip ci]
d6a4c5e 
# [1.26.0](v1.25.0...v1.26.0) (2024-06-29)

### Bug Fixes

* broken features ([742be90](742be90))
* Button placement change causing multi buttons to stop working. ([caed598](caed598))
* color pickers opening when they shouldn't ([b53edd7](b53edd7))
* continue when old and new placement is the same ([dd9b089](dd9b089))
* deep dark author/co author title ([a3503d5](a3503d5))
* features with multi buttons placement issue ([50014cb](50014cb))
* object type not being handled properly ([b34b86e](b34b86e))
* old button placement not being removed ([b995911](b995911))
* playback speed button order issue ([186c4c5](186c4c5))

### Features

* **automatic quality:** Fallback strategy [#461](#461) ([c621580](c621580))
* Disable button's placement select when button isn't enabled [#504](#504) ([916b39c](916b39c))
* forward rewind buttons [#486](#486) ([1a80122](1a80122))
* Hide end screen cards button [#484](#484) ([5e047c5](5e047c5))
* hide paid promotion banner [#519](#519) ([5356f8d](5356f8d))
* Setting search bar ([013ce19](013ce19))

## Release Artifacts
| File Name | SHA-256 Hash |
| :--- | :---: |
| youtube-enhancer-v1.26.0-Chrome.zip | a97eca36b647d176c303bd30096509052695a70152c0f56550a319762e9827a3 |
| youtube-enhancer-v1.26.0-Chromium.zip | a97eca36b647d176c303bd30096509052695a70152c0f56550a319762e9827a3 |
| youtube-enhancer-v1.26.0-Edge.zip | a97eca36b647d176c303bd30096509052695a70152c0f56550a319762e9827a3 |
| youtube-enhancer-v1.26.0-Firefox.zip | 0eee8b8088e4fdbe87b997d252851e4b6918f20180c83574f3405ce2126955fb |
@VampireChicken12
Copy link
Member

@slrgt this feature has been released in version 1.26.0

@VampireChicken12 VampireChicken12 closed this as completed by moving to Done in YouTube Enhancer Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VampireChicken12 VampireChicken12

Labels
complete Use this label for a feature/bug issue that is complete but not released yet enhancement New feature or request released
Projects
YouTube Enhancer
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VampireChicken12 @slrgt