Topics now get 12 partitions by default #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number 12 was chosen to support even load. Counts of 2, 3, 4 and 6 are reasonable for both replicas and consumer group members. At the same time we didn't want a high default number because the sample config file mentions "more files across the brokers". The reason for doing this change is that clients should not assume ordering guarantees unless designed for.
atamon
approved these changes
Nov 28, 2018
solsson
added a commit
that referenced
this pull request
Oct 8, 2019
I though that the feature would be neat for development (with replication factor 1, see #222) but it causes just as much confusion and useless troubleshooting there, for example race conditions between intentional topic creation and a container starting up to produce to the topic. You actually never know which topic config you're getting. Related: #107 The duplication is a workaround for kubernetes-sigs/kustomize#642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number 12 was chosen to support an even load.
Counts of 2, 3, 4 and 6 are reasonable for both replicas and consumer group members.
At the same time we didn't want a high default number because the sample config file
mentions "more files across the brokers".
The reason for doing this change is that clients should not assume ordering guarantees unless designed for.
With #221 we won't use this default a lot, but maybe in the "not designed for" cases.