Disable automatic topic creation #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we want to undo #107. It was partially based on a false assumption, as pointed out in #101 (comment) Topics are created not only at produce but also at for example kafkacat -C. Typos cost us more time than it would take to automate topic creation and run ./bin/kafka-topics.sh in a temporary pod when we haven't automated.
|
LGTM! 👍 Also: 🍰 🍾 Scope creep: Is our topic automation generic/useful enough to include in this open-source project? Maybe a sample job that describes how we do it? |
|
#121 has quite good examples of topic creation |
atamon
approved these changes
Nov 28, 2018
|
Just found #3 :) |
|
It's worth noting here that release notes for 2.1.0 mention "Admin script and admin client API improvements to simplify admin operation (KIP-231, KIP-308, KIP-322, KIP-324, KIP-338, KIP-340)" |
now that we're running Java 11. Chosen based on trial and error: 80Mi got OOMKilled, 100m cpu took >twice the time to complete.
solsson
added a commit
that referenced
this pull request
Nov 28, 2018
|
There's a standalone topic creation example, with resource limits, now in events-kube. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit comment for why.