Prevent duplicate notices #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `admin_notices` hook is created, raise a flag in a global variable to avoid hooking multiple times. See Yoast#36
|
It looks like I can't use I may need some inputs on how I can mock global functions, I can deal with the tests, provided you want me to do that. |
|
Not to be pushy, but will this PR be merged (even without tests)? I'm preparing a new major release and I would like to include this library to start nagging our users :) |
|
@sciamannikoo No problem, I have asked our plugin team to take a look at the pull request. |
|
Code Review: 👍 , acceptance: 👍 I might get back on creating unit tests. |
DrewAPicture
added a commit
to DrewAPicture/whip
that referenced
this pull request
Aug 4, 2017
…d the need for a global.
jcomack
added a commit
that referenced
this pull request
Aug 8, 2017
Effectively revert #37 in favor of a hook-based solution for duplicate notices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
admin_noticeshook is created, raise a flag in a global variable to avoid hooking multiple times.See #36
I would like to add tests coverage to this whole class, but I'd need to add
10up/wp_mock,lucatume/function-mockeror something similar to mock global functions such aswp_kses.If that's not a problem, I can add tests to this PR in a separate commit.