Merge pull request #44 from DrewAPicture/no-mo-globals

Effectively revert #37 in favor of a hook-based solution for duplicate notices

src/facades/wordpress.php

@@ -31,6 +31,18 @@ function whip_wp_check_versions( $requirements ) {
 		$dismisser = new Whip_MessageDismisser( time(), $dismissThreshold, new Whip_WPDismissOption() );
 
 		$presenter = new Whip_WPMessagePresenter( $checker->getMostRecentMessage(), $dismisser, $dismissMessage );
-		$presenter->register_hooks();
+
+		// Prevent duplicate notices across multiple implementing plugins.
+		if ( ! has_action( 'whip_register_hooks' ) ) {
+			add_action( 'whip_register_hooks', array( $presenter, 'register_hooks' ) );
+		}
+
+		/**
+		 * Fires during hooks registration for the message presenter.
+		 *
+		 * @param \Whip_WPMessagePresenter $presenter Message presenter instance.
+		 */
+		do_action( 'whip_register_hooks', $presenter );
+
 	}
 }

src/presenters/Whip_WPMessagePresenter.php

@@ -28,17 +28,12 @@ public function __construct( Whip_Message $message, Whip_MessageDismisser $dismi
 	}
 
 	/**
-	 * Registers hooks to WordPress. This is a separate function so you can
-	 * control when the hooks are registered.
+	 * Registers hooks to WordPress.
 	 *
+	 * This is a separate function so you can control when the hooks are registered.
 	 */
 	public function register_hooks() {
-		global $whip_admin_notices_added;
-
-		if ( null === $whip_admin_notices_added || ! $whip_admin_notices_added ) {
-			add_action( 'admin_notices', array( $this, 'renderMessage' ) );
-			$whip_admin_notices_added = true;
-		}
+		add_action( 'admin_notices', array( $this, 'renderMessage' ) );
 	}
 
 	/**