Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for NS7 #388

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support for NS7 #388

wants to merge 2 commits into from

Conversation

autaut03
Copy link

@autaut03 autaut03 commented Sep 15, 2020

  • had to bump typescript version
  • dropped deprecated tns-core-modules and nativescript-angular deps
  • updated Angular to 10 in demo-angular
  • ran tslint in all projects: demo, demo-angular and mapbox itself

@@ -490,7 +490,7 @@ declare class MGLEmptyFeature extends MGLShape implements MGLFeature {

readonly title: string; // inherited from MGLAnnotation

readonly // inherited from NSObjectProtocol
readonly; // inherited from NSObjectProtocol
Copy link
Contributor

@Codex- Codex- Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These readonly; statements are extraneous, can be removed as they do not actually do anything in many cases, although there are likely some readonlys, followed by a newline, and valid syntax. The code gen isn't great.

@cvietor
Copy link

cvietor commented Oct 7, 2020

any update or schedule for this one? let me know if a helping hand is needed

@autaut03
Copy link
Author

autaut03 commented Oct 7, 2020

@cvietor I'll close the task today, but otherwise this needs to be tested (CI isn't configured for PRs) and merged by someone.

@Yermo
Copy link
Owner

Yermo commented Oct 7, 2020

@autaut03 Yea, I need to get back to working on the plugin and merge a number of PRs. I've been swamped for the last few months with a project that's taking 100%+ of my time but is finally nearing an end. Then I will spend a few weeks focused on the plugin. I apologize about the delay.

@madmas madmas mentioned this pull request Oct 12, 2020
@cvietor
Copy link

cvietor commented Oct 15, 2020

@autaut03 i tried to run your PR and it seems to be working (some styles in angular demo seem to be messed up, but that could be my machine).
i noticed that the demo app (core, non-ng) is not yet migrated to ns7, which should run smoothly with ns migrate

@cvietor
Copy link

cvietor commented Oct 31, 2020

@autaut03 seems you and me just tried android, your PR does not work on iOS. but there is not much to do to fix that:

  • in mapbox.ios.ts add @NativeClass() decorator to:
    • class MGLMapViewDelegateImpl
    • class MapTapHandlerImpl
    • class MapLongPressHandlerImpl
    • class MapPanHandlerImpl
    • class MapSwipeHandlerImpl
  • add ts-patch to src/package.json
  • modify npm build script: "scripts": { "build": "npm i && ts-patch install && tsc --skipLibCheck", ...
  • add "plugins" section to src/tsconfig.json:
"plugins": [{
  "transform": "@nativescript/webpack/transformers/ns-transform-native-classes",
  "type": "raw"
}]

@farfromrefug
Copy link

the mapbox plugin is now an will remain maintained at @nativescript-community https://github.com/nativescript-community/ui-mapbox. We released the new plugin for N7 with a lot of fixes https://www.npmjs.com/package/@nativescript-community/ui-mapbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants