Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with NS7 #387

Open
autaut03 opened this issue Sep 15, 2020 · 10 comments
Open

Doesn't work with NS7 #387

autaut03 opened this issue Sep 15, 2020 · 10 comments

Comments

@autaut03
Copy link

Hey. As far as I'm aware, this needs to be recompiled to target es2017 to work with NS7 correctly. Currently, when trying to use it with NS7, it throws this error while trying to instantiate the map component:

JS: ERROR Error: Uncaught (in promise): TypeError: Class constructor ContentView cannot be invoked without 'new'
JS: TypeError: Class constructor ContentView cannot be invoked without 'new'
JS:     at MapboxViewCommonBase [as constructor] (file: node_modules\nativescript-mapbox\mapbox.common.js:73:0)
JS:     at MapboxViewBase [as constructor] (file: node_modules\nativescript-mapbox\mapbox.common.js:281:0)
JS:     at new MapboxView (file: node_modules\nativescript-mapbox\mapbox.android.js:20:0)
JS:     at ViewUtil.createView (file: node_modules\@nativescript\angular\__ivy_ngcc__\fesm2015\nativescript-angular.js:2550:0)
@Yermo
Copy link
Owner

Yermo commented Sep 15, 2020

Ok. Thanks for letting me know. I'm behind schedule on my end and had hoped to loop back around to the plugin before now. I haven't upgraded to NS7 yet. I don't have an ETA when I'll get back to it but it shouldn't be too much longer now. If you want to take a crack at it and create a pull request I can take the time out to review it. Otherwise, hopefully in the next few weeks I can get to it. I apologize for the delay.

@autaut03
Copy link
Author

No worries. I delay my (much smaller) OS projects too. I'll try my best with a PR.

@trevortos
Copy link

Having the same issue here, non angular / vue app.

@codeturn
Copy link

codeturn commented Oct 4, 2020

Me too. Vue app. Please make update.

@jeffersondossantosaguiar

Me too. I've the same problem

@madmas
Copy link
Contributor

madmas commented Oct 12, 2020

@trevortos @codeturn @jeffersondossantosaguiar here is a PR open for this: #388
I you need this, too, maybe you can check it out and validate the changes work as expected? I think that will make it a lot easier for @Yermo to merge it when he get to it ;-)
I'm planning to do so and want to validate the PR ASAP

@farfromrefug
Copy link

I am in the need on that plugin on N 7.
I will create a fork under @nativescript-community. I really hope that is ok. I tried to contact @Yermo but now answer, i hope it is ok with you.
If we all agree we can start maintaining it there (which makes more sense), and people are welcome to join @nativescript-community to contribute more and in an easier way

@Yermo
Copy link
Owner

Yermo commented Nov 12, 2020

My apologies that I have been MIA. I had hoped to get back to working on the plugin much sooner but life keeps conspiring to get in the way. If you need to fork it, please go ahead. Of course it's ok.

@farfromrefug
Copy link

@Yermo done and released a "first version". already quite a lot of changes
Thanks

@farfromrefug
Copy link

the mapbox plugin is now an will remain maintained at @nativescript-community https://github.com/nativescript-community/ui-mapbox. We released the new plugin for N7 with a lot of fixes https://www.npmjs.com/package/@nativescript-community/ui-mapbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants