Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing enum->str mappings from Init_Trajectory_Status #63

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Add missing enum->str mappings from Init_Trajectory_Status #63

merged 2 commits into from
Jun 16, 2023

Conversation

gavanderhoorn
Copy link
Collaborator

Fixes #7.

@gavanderhoorn gavanderhoorn added this to the 0.1.1 milestone Jun 16, 2023
@gavanderhoorn
Copy link
Collaborator Author

I'm wondering whether we should refactor this and move it to a function in ErrorHandling instead. The enum keeps growing, and with it the nr of lines mapping them to a char[].

We might also want to store these strings in a ROS .msg, like we do with the MotionNotReadyCode messages.

@gavanderhoorn
jtc: map enum to str for all traj validation results
cf2e1f0 
Add the ones from Init_Trajectory_Status that were missing.
@gavanderhoorn
Wrap very long lines
5631cda
@gavanderhoorn gavanderhoorn force-pushed the add_missing_fjt_enum_str_mappings branch from a9b127a to 5631cda Compare June 16, 2023 16:59
ted-miller
ted-miller approved these changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@ted-miller ted-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might also want to store these strings in a ROS .msg, like we do with the MotionNotReadyCode messages.

Probably not a bad idea, for the sake of consistency.

@ted-miller ted-miller merged commit 5d594ee into Yaskawa-Global:main Jun 16, 2023
@gavanderhoorn gavanderhoorn deleted the add_missing_fjt_enum_str_mappings branch June 16, 2023 19:52
@gavanderhoorn gavanderhoorn mentioned this pull request Jun 16, 2023
Closed
@gavanderhoorn
Copy link
Collaborator Author

We might also want to store these strings in a ROS .msg, like we do with the MotionNotReadyCode messages.

Probably not a bad idea, for the sake of consistency.

Tracking in #67.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ted-miller ted-miller ted-miller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.1
Development

Successfully merging this pull request may close these issues.

"generic failure" returned by action server for "final pt must have accel 0" error
2 participants
@gavanderhoorn @ted-miller