Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle bytes with rencode #84

Closed
totaam opened this issue Aug 1, 2021 · 3 comments
Closed

handle bytes with rencode #84

totaam opened this issue Aug 1, 2021 · 3 comments
Assignees
@totaam
Labels
enhancement New feature or request network

Comments

@totaam
Copy link
Collaborator

totaam commented Aug 1, 2021 •
edited
Loading

Now that we have a maintainable javascript version of rencode: #18.
Same as Xpra-org/xpra#3229
@totaam totaam self-assigned this Aug 1, 2021
@totaam totaam added enhancement New feature or request network labels Aug 1, 2021
@totaam totaam mentioned this issue Aug 1, 2021
Closed
@totaam
Copy link
Collaborator Author

totaam commented Aug 1, 2021

Already made some fixes:

totaam added a commit that referenced this issue Aug 3, 2021
@totaam
#84 add support for 'rencodeplus'
1f83163
@totaam
Copy link
Collaborator Author

totaam commented Aug 3, 2021

The new code works very well and avoids doing slow copies in the protocol code.

AES mode still needs fixing though.. (now also broken with bencode !?)

This was referenced Aug 3, 2021
Closed
Closed
Closed
@totaam
Copy link
Collaborator Author

totaam commented Aug 3, 2021

AES and lz4 also fixed!

@totaam totaam closed this as completed Aug 3, 2021
totaam added a commit that referenced this issue Aug 7, 2021
@totaam
#84 use a DataView to handle signed / unsigned data 'natively'
8406a6a
totaam added a commit that referenced this issue Aug 8, 2021
@totaam
#84 utf8 fixes, add sanity checks
7f17789
totaam added a commit that referenced this issue Aug 9, 2021
@totaam
#84 backwards compatibility for plain 'rencode'
13c894d 
use the simple Uint8ToString and Uint8ToString for string data
it may not be correct but it is 100% reversible whereas utf8ByteArrayToString and stringToUtf8ByteArray are not?
@totaam totaam mentioned this issue Aug 16, 2021
Open
totaam added a commit that referenced this issue Aug 31, 2021
@totaam
#84 remove unnecessary churn
f278ad9
totaam added a commit that referenced this issue Aug 31, 2021
@totaam
#84 fixup f278ad9
625e3fb 
we do need to convert utf8 with the legacy packet encoders
@totaam totaam mentioned this issue Mar 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@totaam totaam

Labels
enhancement New feature or request network
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@totaam