Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize the html5 client #16

Open
totaam opened this issue Feb 21, 2019 · 7 comments
Open

modernize the html5 client #16

totaam opened this issue Feb 21, 2019 · 7 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Feb 21, 2019

The code is old and ugly.
We should take advantage of modern browser technologies to cleanup the code.

@totaam
Copy link
Collaborator Author

totaam commented Feb 26, 2019

@totaam
Copy link
Collaborator Author

totaam commented Jul 22, 2019

I'm not getting any help on this, and I still firmly believe that JavaScript is an awful language.
So don't expect miracles.

@totaam
Copy link
Collaborator Author

totaam commented Aug 20, 2019

2019-08-20 12:45:15: Praecantatio commented


All is not yet lost: there are two forks with potential:

https://github.com/andersevenrud/xpra-html5-client

https://github.com/sagemathinc/cocalc/blob/master/src/smc-webapp/frame-editors/x11-editor/xpra/README.md

For even greater performance and speed, might want to consider WASM and WebRTC

@totaam
Copy link
Collaborator Author

totaam commented Feb 14, 2020

For even greater performance and speed, might want to consider WASM and WebRTC

FWIW:

  • wasm already in use where it is useful: h264 decoding via broadway
  • webrtc: hell no!

@totaam
Copy link
Collaborator Author

totaam commented Feb 19, 2020

2020-02-19 18:28:07: Praecantatio commented


Why not WebRTC?

@totaam
Copy link
Collaborator Author

totaam commented Nov 28, 2020

Why not WebRTC?

Maybe one day: Xpra-org/xpra#1338
WebTransport is a much better fit: #143

@totaam
Copy link
Collaborator Author

totaam commented Aug 16, 2021

Not sure this qualifies as modernizing, but switching to https://github.com/Benzinga/lz4js for lz4 greatly simplifies the codebase. From 7000 lines of unreadable JS to just 750.
I merged the 3 separate files by hand to avoid the requirejs mess: we don't want asynchronous loading and the whole define function incompatibility problems that spring up everywhere because of it.
And I added a utility decode function to simplify calling into lz4 since we only use it for decompressing packets with the size header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant