This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(disk): add broken disk check while initialize #834
feat(disk): add broken disk check while initialize #834
Changes from all commits
c552285
71708ca
5ed2a19
5f0972e
85fba40
97e5015
5cdf258
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you should assert data_dirs.size() == data_dir_tags.size() here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data_dirs and data_dirs_tags are
_options.data_dirs
and_options.data_dir_tags
, you can reference how them set inreplication_common.cpp
functioninitialize
, I don't add a link here because it will be refactored by pull request 831.