This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(disk): add broken disk check while initialize #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
May 22, 2021
Smityz
reviewed
May 25, 2021
| std::string err_msg; | ||
| int count = 0; | ||
| std::vector<std::string> available_dirs; | ||
| std::vector<std::string> available_dir_tags; |
There was a problem hiding this comment.
maybe you should assert data_dirs.size() == data_dir_tags.size() here
There was a problem hiding this comment.
data_dirs and data_dirs_tags are _options.data_dirs and _options.data_dir_tags, you can reference how them set in replication_common.cpp function initialize, I don't add a link here because it will be refactored by pull request 831.
acelyc111
previously approved these changes
May 28, 2021
levy5307
reviewed
Jun 2, 2021
levy5307
reviewed
Jun 3, 2021
levy5307
reviewed
Jun 3, 2021
levy5307
reviewed
Jun 3, 2021
levy5307
approved these changes
Jun 4, 2021
The case need add perf-counter and let user know it in time |
foreverneverer
approved these changes
Jun 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds disk check while initialize. We choose the way that doris used. When the disk path is found, we will try to write and read data to check if the disk is broken. If the disk is broken, it will be excluded and replica instance can start. In previous implmenetation, if a disk is broken, replica server will core and never start until the broken disk removed.
This pull request also adds related unit tests and configuration.
[replication] +ignore_broken_disk=true