can tracable variable #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The variable $nestedVar belongs to test.scss
|
|
@danny007in Is there any way to contact you privately? (Before you fix the earlier mentioned bug ;) ) |
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Jan 30, 2021
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. co-authored by [email protected] fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124
You can discuss here, so every can see wants going on this PR |
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Jan 30, 2021
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. Co-authored-by danny007in [email protected] fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Jan 30, 2021
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. Co-authored-by: danny007in [email protected] fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Jan 30, 2021
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. Co-authored-by: danny007in <[email protected]> fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Jan 30, 2021
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. Co-Authored-By: danny007in <[email protected]> fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Jan 30, 2021
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. Co-Authored-By: Daniel <[email protected]> fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Jan 30, 2021
Co-Authored-By: Daniel <[email protected]> Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Jan 30, 2021
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124 Co-Authored-By: Daniel <[email protected]>
|
I like your Idea. However, if see it right, it introduces a quadratic runtime for setting the file paths. I incorporated your approach into PR #125 without that overhead, shrinked the code since your approach allows that and adjusted the results to be backwards compatible to not introduce a breaking change. Furthermore, I plan issue another pull request that is based on the current one. Thanks for your valuable help :D |
|
For example, its easier to set the file path for each variable for creating reports in files, since, e.g., the SonarQube generic issues format requires that. |
danny007in
force-pushed
the
info-improve
branch
from
c51ee50 to
6b6fc78
Compare
Breaking Change Co-Authored-By: Georg Gentzen <[email protected]>
danny007in
force-pushed
the
info-improve
branch
from
6b6fc78 to
445f6ec
Compare
gentzeng
suggested changes
Jan 31, 2021
Comment on lines
+53
to
+57
| variables.forEach(sassVar => { | ||
| if (sassVar.filePath === '') { | ||
| sassVar.filePath = file; | ||
| } | ||
| }); |
There was a problem hiding this comment.
This is introducing quadratic overhead and is hence inefficient. Just add the filename with the parse function in line 51 as I did in PR #125
There was a problem hiding this comment.
Furthermore, as written above, its easier to set the file path for each variable for creating reports in files, since, e.g., the SonarQube generic issues format requires that.
|
This is not a breaking change anymore. However, the Readme needs to be updated. You can find a version in PR #125, so you can save some time. |
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Jan 31, 2021
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124 Co-Authored-By: Daniel <[email protected]>
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Jan 31, 2021
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124 Co-Authored-By: Daniel <[email protected]>
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Jan 31, 2021
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124 Co-Authored-By: Daniel <[email protected]>
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Feb 2, 2021
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124 Co-Authored-By: Daniel <[email protected]>
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Feb 17, 2021
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124 Co-Authored-By: Daniel <[email protected]>
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Mar 3, 2021
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124 Co-Authored-By: Daniel <[email protected]>
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Mar 3, 2021
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124 Co-Authored-By: Daniel <[email protected]>
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Mar 3, 2021
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124 Co-Authored-By: Daniel <[email protected]>
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Mar 3, 2021
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124 Co-Authored-By: Daniel <[email protected]>
gentzeng
added a commit
to gentzeng/find-unused-sass-variables
that referenced
this pull request
Mar 3, 2021
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124 Co-Authored-By: Daniel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highly helped by this PR #123
Co-Authored-By: Georg Gentzen [email protected]