Combine Folders Feature Added #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny007in
force-pushed
the
combine-feature
branch
from
cb84ab7 to
7ef5a5f
Compare
danny007in
force-pushed
the
combine-feature
branch
from
7ef5a5f to
cd468d4
Compare
XhmikosR
reviewed
Jan 5, 2021
danny007in
force-pushed
the
combine-feature
branch
from
1eb3543 to
eca23a7
Compare
|
can merge |
danny007in
force-pushed
the
combine-feature
branch
from
e5ac39b to
11edb83
Compare
Open
|
I like this feature. I am currently trying to rebase it with PR #125 to avoid conflicts. Hope you don't mind |
|
Year, that is exactly what I meant. I just fetched your PR #115 to my local repository to update it and to propose it to you. I'm not changing anything here and will notice you, when my proposal is ready for your review |
|
Alright |
6 tasks
|
does this feature implemented in main branch? |
|
I don't think it is. You could try rebasing and maybe @GeoSot or I could have a look later. |
|
This needs a proper rebase and make sure that lint and tests pass. Feel free to make a proper, new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can combine folders with another folder and lint within as same array result
Normal without combine
fusv build/scss node_modules/bootstrap/scssWith combine Feature
fusv build/scss node_modules/bootstrap/scss -c