Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add russian language #83

Merged
merged 7 commits into from
Mar 13, 2024
Merged

add russian language #83

merged 7 commits into from
Mar 13, 2024

Conversation

sega-gremlen
Copy link
Contributor

No description provided.

@Xewdy444 Xewdy444 added the enhancement New feature or request label Mar 3, 2024
@Xewdy444 Xewdy444 linked an issue Mar 3, 2024 that may be closed by this pull request
@Xewdy444
Copy link
Owner

Xewdy444 commented Mar 3, 2024

Thanks! I'll get this merged soon.

@sega-gremlen
Copy link
Contributor Author

I noticed you take off the "." out of the captcha text. This is not the mistake, the symbol is actually in text in some phrases.

1 2

3 4

One more thing that I forgot to mention is that I tested the script only on audio captchas. As I understand, for image captchas, this part still needs to be translated:

object_dict = {
            "taxis": "/m/0pg52",
            "bus": "/m/01bjv",
            "school bus": "/m/02yvhj",
            "motorcycles": "/m/04_sv",
            "tractors": "/m/013xlm",
            "chimneys": "/m/01jk_4",
            "crosswalks": "/m/014xcs",
            "traffic lights": "/m/015qff",
            "bicycles": "/m/0199g",
            "parking meters": "/m/015qbp",
            "cars": "/m/0k4j",
            "bridges": "/m/015kr",
            "boats": "/m/019jd",
            "palm trees": "/m/0cdl1",
            "mountains or hills": "/m/09d_r",
            "fire hydrant": "/m/01pns0",
            "stairs": "/m/01lynh",
        }

But I don't have the CapSolver API to test images, so I can only provide a translation of these words.

@Xewdy444
Copy link
Owner

Xewdy444 commented Mar 3, 2024

I noticed you take off the "." out of the captcha text. This is not the mistake, the symbol is actually in text in some phrases.

I do this because the period is excluded in the message sometimes, so I want to still match the text in that case. The regex pattern will match regardless of the period being present or not.

I went ahead and added the Russian translations for the reCAPTCHA objects. I believe they are correct, but I would ask that you check them over to be sure.

@sega-gremlen
Copy link
Contributor Author

After about 20-30 minutes of clicking, I didn't get the following items: parking meters, boats, palm trees, mountains, or hills.
I believe it's quite rare.
I corrected some translation inaccuracies that I encountered.

However, I didn't see a school bus, instead, I saw two different types of buses. The Russian translation shows them as "bus" and "buses" (plural form), i don't know why.

@Xewdy444
Copy link
Owner

Xewdy444 commented Mar 3, 2024

In that case, both translations can be put in the "bus" translations. Do you know any websites with a Russian reCAPTCHA that I could test this on?

@sega-gremlen
Copy link
Contributor Author

sega-gremlen commented Mar 3, 2024

In that case, both translations can be put in the "bus" translations. Do you know any websites with a Russian reCAPTCHA that I could test this on?

You can try it on demo captcha, just use locale:

context = browser.new_context(locale='RU')

Or this page: https://www.fl.ru/account/login/

@Xewdy444
Copy link
Owner

Xewdy444 commented Mar 3, 2024

Perfect, thank you. I will test this out later today and see if I can check the remaining translations.

@Xewdy444
Copy link
Owner

Xewdy444 commented Mar 7, 2024

I added an alternate translation for fire hydrant. I also did not get the items that you listed, so I was not able to confirm if they are translated correctly. I would say that this is fine, because in the rare chance that someone does get one of those items and it is mistranslated, it will just be skipped without counting it as a solve attempt.

Xewdy444 added 2 commits March 8, 2024 17:24
The school bus object is not needed as CapSolver doesn't support it (anymore?).
@Xewdy444 Xewdy444 merged commit 443dc91 into Xewdy444:main Mar 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add language PR
2 participants