-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add language PR #75
Comments
I would be willing to implement this. The author of that pull request closed it as it was incomplete, however his idea can still be used. I will need translations for the text used for locators in recaptcha_box.py. This format would be fine: TRANSLATIONS = {
"im_not_a_robot": ["I'm not a robot", "로봇이 아닙니다"],
"get_an_audio_challenge": ["Get an audio challenge", "음성 보안문자 듣기"],
"get_a_new_challenge": ["Get a new challenge", "보안문자 새로 받기"],
} Another possible concern is transcribing the audio challenge for other languages of reCAPTCHA. The reason for my concern is that the |
For Russian captchas, the audio check is also in English, so your script works fine on Russian captchas with translation. Did I understand you correctly that you want to select a language by index? Something like that:
Too bad playwright can't select the tag itself from the list, or am I missing something? |
Great, this will work fine then. I'll probably end up doing something like this: @property
def checkbox(self) -> Locator:
"""The reCAPTCHA checkbox locator."""
return self.anchor_frame.get_by_role("checkbox", name=re.compile("|".join(TRANSLATIONS["im_not_a_robot"]))) This will generate a regex pattern that will match any of the translations for the text of that locator. |
Do you have the Russian translations for the reCAPTCHA text? |
Yeah, I have all the translations except:
I don't know how to call this case. I know I'm a little slow on the PR, I'll try to get it done in the next 2 days ok? Too little time. |
I can add another language (tested on audio messages), but I don't know the best way to add a language selection feature.
I saw a PR with adding Korean (#43), but it was rejected for some reason. Maybe the author can tell me how he wants to implement multi-language?
The text was updated successfully, but these errors were encountered: