Add environment variable overrides for key strings #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't reuse code at all; the same `match` is peppered through every place the domain name appears. Contains unused fn that encapsulates the `match` but I haven't been able to figure out how to make it callable from within a Maud template yet.
Actually reuses code now; I was stupid for using `async fn`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this PR as a draft with only the domain-name functionality implemented so far, because the other components of #5 are basically a copy-paste job unless there's some higher-level feedback to be had about the approach I'm taking.
As previously mentioned, I've never worked in Rust before, so it seemed best to start with the smallest possible diff and pause in case I did something noob-y that should be corrected before building on this. If there's a better way to do it, I'll gladly experiment more—then build the rest of the items in the same style and push a cleaned-up history minus the WIP commits.