-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom timeout for requests #687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions TODO: set up integration tests to ensure that high latency commands (like ledger) do not timeout within the default 10 seconds
mvadari
reviewed
Feb 15, 2024
mvadari
reviewed
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like this PR actually modifies the external-facing methods.
… of this parameter
…ntation detail of the request method
justinr1234
approved these changes
Mar 5, 2024
mvadari
reviewed
Mar 5, 2024
i just happened to see this. it looks good to me! great idea :) |
pdp2121
approved these changes
May 7, 2024
thank you for the reviews. If there are no more objections, I'd like to merge this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Certain requests could take more time to return a response, than the default
10 seconds
duration. This change allows users to specify a custom timeout parameter to all requests.Additionally, this PR sets up uniform interfaces for all
Client._request_impl
overridden functions.Context of Change
In the present code, all requests are given 10 seconds duration to return a response. Any longer latency results in a timeout. This is inconvenient for certain commands that are known to take up more time, for instance,
admin
-only commands like theledger
command.Type of Change
Did you update CHANGELOG.md?
Test Plan
This is an existing integration test that invokes the
ledger
command attests/integration/reqs/test_ledger.py
. Which other command might take up more time?