Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeout parameter to network client request method #523

Closed
rikublock opened this issue Feb 20, 2023 · 1 comment
Closed

add timeout parameter to network client request method #523

rikublock opened this issue Feb 20, 2023 · 1 comment

Comments

@rikublock
Copy link
Contributor

There are several cases where making a request can take an extended amount of time. For instance making any "admin only" request will very likely cause a timeout (reference https://xrpl.org/ledger.html)

Having hard-coded values makes it very difficult to work around the problem.
https://github.com/XRPLF/xrpl-py/blob/master/xrpl/asyncio/clients/json_rpc_base.py#L15

There should be an easy way to turn off and/or overwrite the timeout when making requests.

@mvadari
Copy link
Collaborator

mvadari commented Sep 17, 2024

This was solved by #687

@mvadari mvadari closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants