Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

740: Improve complex forms performance - follow up - IANA test/update, move comment #742

Merged
merged 3 commits into from
Dec 9, 2024
Merged

740: Improve complex forms performance - follow up - IANA test/update, move comment #742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e67d3aa
add: test for >2 char iana tags, tag list update script, updated tags
lindsay-stevens Dec 9, 2024
0fad57d
fix: move comment to relevant lines
lindsay-stevens Dec 9, 2024
2c878a3
add: test results for performance test cases
lindsay-stevens Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyxform/parsing/expression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ def tokenizer(scan, value) -> ExpLexerToken | str:
return re.Scanner(lexicon)


# Scanner takes a few 100ms to compile so use this shared instance.
class ExpLexerToken:
__slots__ = ("name", "value", "start", "end")

Expand All @@ -85,6 +84,7 @@ def __init__(self, name: str, value: str, start: int, end: int) -> None:
self.end: int = end


# Scanner takes a few 100ms to compile so use these shared instances.
_EXPRESSION_LEXER = get_expression_lexer()
_TOKEN_NAME_LEXER = get_expression_lexer(name_only=True)

Expand Down
Loading
Loading