740: Improve complex forms performance - follow up - IANA test/update, move comment #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test_language_warnings.py
- add case for a valid >2 char language code
- add case for invalid 3 char code - example of behaviour where if
someone refers to ISO 639 and gets a valid tag but that's not
compliant with the IANA RFC which uses the shortest available tag.
- subtags_updater.py
- add script to simplify/formalise how the tag lists are prepared.
I don't know how/where the original list was obtained but this
produces a purely additive changeset consistent with a published
changelist https://www.iana.org/assignments/lang-subtags-templates/lang-subtags-templates.xhtml
so it should be about right.
- add IANA language codes added to registry since list was originally
committed 6+ years ago (2018-04-01)
4 tasks
- generally quite a bit faster now but there seems to be something still
potentially wrong when translations and/or lots of choices/itemsets
are involved, e.g. 10K text = ~5 seconds,
vs 10K select + 20K choices = ~80 seconds.
- switched to using `convert()` directly since this now accepts
markdown input, and it avoids potentially confounding effects of
extra things done in `assertPyxformXform` (such as re-parsing XML).
- this had a minor impact (approx 10%) on test execution time but
considerable impact (approx 30%) on memory usage.
lindsay-stevens
force-pushed
the
iana-subtags
branch
from
a8de88f to
2c878a3
Compare
lognaturel
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #740 feedback.
Addresses this comment:
And this comment:
Also updates results in performance test cases.
Why is this the best possible solution? Were any other approaches considered?
Detailed notes in commit message and docstrings / inline comments.
For the updater script, considered having it also pull from the URL rather than save manually, but 1) I don't expect that this tag list will require regular updates (last updated 6 years ago) for it to be worth streamlining it further, and 2) by the time another update is done or needed the relevant URL might be different. The main value of the script is having a documented and reproducible way to generate the code lists.
What are the regression risks?
None
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No
Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code