-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gists+examples: Extend GistsHandler
through star(...)
, unstar(...)
, is_starred(...)
#330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
envp
force-pushed
the
issue-27/star-gists
branch
from
April 9, 2023 18:12
2ee5c90
to
762f229
Compare
envp
changed the title
gists+examples: Extend
gists+examples: Extend Apr 9, 2023
GistsHandler
by adding star(...)
GistsHandler
through star(...)
, unstar(...)
envp
force-pushed
the
issue-27/star-gists
branch
from
April 9, 2023 18:29
762f229
to
cfe9a8a
Compare
The `star(...)` function takes a `gist_id` and 'stars' it. Has no observable effect on the gist if it is already starred.
The `unstar(...)` function takes a `gist_id` and removes a 'star' from it. Has no observable effect on the gist if it is not starred.
Create `GistsHandler::is_starred`. This acceepts a `gist_id` and returns if a gist is starred.
This fully demonstrates how to: - Check if a gist is starred - Star a gist - Unstar a gist
envp
force-pushed
the
issue-27/star-gists
branch
from
April 9, 2023 18:54
8ce1986
to
ca7cd8d
Compare
envp
changed the title
gists+examples: Extend
gists+examples: Extend Apr 9, 2023
GistsHandler
through star(...)
, unstar(...)
GistsHandler
through star(...)
, unstar(...)
, is_starred(...)
cc: @XAMPPRocky this is ready for review. Thanks for your patience with the PR spam :^) |
envp
commented
Apr 9, 2023
@envp Thank you for your PR! Spam would imply that it's unwelcome or not wanted, which I can assure you, your contributions are not. 🙂 |
Thank you for your PR! |
Libbum
pushed a commit
to Libbum/octocrab
that referenced
this pull request
Apr 10, 2023
….)`, `is_starred(...)` (XAMPPRocky#330) * gists+examples: Extend `GistsHandler` by adding `star(...)` The `star(...)` function takes a `gist_id` and 'stars' it. Has no observable effect on the gist if it is already starred. * gists+examples: Extend `GistsHandler` by adding `unstar(...)` The `unstar(...)` function takes a `gist_id` and removes a 'star' from it. Has no observable effect on the gist if it is not starred. * examples: Rename star_a_gist -> star_unstar_a_gist * gists: Add function to check if a gist is starred Create `GistsHandler::is_starred`. This acceepts a `gist_id` and returns if a gist is starred. * examples: Extend the `star_unstar_a_gist` example This fully demonstrates how to: - Check if a gist is starred - Star a gist - Unstar a gist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding code related to
/gists/{gist_id}/star
here.TODO:
PUT /gists/{gist_id}/star
)DELETE /gists/{gist_id}/star
)GET /gists/{gist_id}/star
)Related to: #27