Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gists API #27

Closed
XAMPPRocky opened this issue Jul 11, 2020 · 8 comments · Fixed by #371
Closed

Add Gists API #27

XAMPPRocky opened this issue Jul 11, 2020 · 8 comments · Fixed by #371

Comments

@XAMPPRocky
Copy link
Owner

No description provided.

@envp
Copy link
Contributor

envp commented Apr 6, 2023

@XAMPPRocky is there still interest in reviewing a contribution for this?

@XAMPPRocky
Copy link
Owner Author

@envp Contibutions are always welcome and encouraged 🙂

@envp
Copy link
Contributor

envp commented Apr 8, 2023

@envp Contibutions are always welcome and encouraged 🙂

Thanks! I've made a couple of PRs to familiarize myself.

@envp
Copy link
Contributor

envp commented Apr 8, 2023

I've tried to tabulate what the TODOs would be acc to GitHub API docs (API Version 2022-11-28)

let me know if I missed something.

@envp
Copy link
Contributor

envp commented Apr 8, 2023

@XAMPPRocky Some of github's APIs (e.g PUT /gists/{gist_id}/star) return an empty response body on success, these can't be deserialized with the current FromResponse trait which assumes there's always valid JSON.

I tried implementing FromResponse for () so callers can ask to discard the response body. However, that conflicts with the current implementation. WDYT is a good way to handle this?

@XAMPPRocky
Copy link
Owner Author

XAMPPRocky commented Apr 8, 2023

@envp There are other parts of the API that do that, in general for those you should use the _ prefixed versions in the Octocrab client like _put that do no processing on the response.

@envp
Copy link
Contributor

envp commented Apr 16, 2023

@XAMPPRocky Not sure how important these three are. I personally don't have a use-case for the bulk gist retrival endpoints (GET /gists[/public]). And GET /users/{username}/gists seems to (slightly) overlap with the endpoint for retrieving the authenticated user's gists.

List gists for a user (GET /users/{username}/gists)
List all public gists (GET /gists)
List public gists (GET /gists/public)

Will continue on these if you think they're useful to have. Thanks again :)

@XAMPPRocky
Copy link
Owner Author

Will continue on these if you think they're useful to have.

In general the goal of the project is to support as much of GitHub's API as possible, so adding support for these APIs is always useful and appreciated if you want to contribute them. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants