Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discussions] How to separate python kernel and nodejs kernel #1008

Closed
xgdyp opened this issue Oct 20, 2022 · 9 comments
Closed

[Discussions] How to separate python kernel and nodejs kernel #1008

xgdyp opened this issue Oct 20, 2022 · 9 comments
Assignees
@xgdyp
Labels
kind/discussion Category issues related to discussion kind/question Category issues related to questions or problems waiting for author need issue author's feedback
Milestone
Add more communit...

Comments

@xgdyp
Copy link
Contributor

xgdyp commented Oct 20, 2022

Hi All, as @frank-zsy said in #968, we need to separate two kernel so developers can focus on one. But now I don't have ideas on how to organize code. One possible method is to create folders like src/node/ and src/python/`. Is there any other possible methods？
@open-digger-bot open-digger-bot bot added kind/discussion Category issues related to discussion kind/question Category issues related to questions or problems labels Oct 20, 2022
@github-actions github-actions bot added the waiting for repliers need other's feedback label Oct 20, 2022
@zhicheng-ning
Copy link
Member

Sounds great, but it's carefully to organize the code since there is a dependency between codes.

@github-actions github-actions bot added waiting for author need issue author's feedback and removed waiting for repliers need other's feedback labels Oct 20, 2022
@xgdyp
Copy link
Contributor Author

xgdyp commented Oct 21, 2022

Thanks @bifenglin's advice. How about this?
image

@github-actions github-actions bot added waiting for repliers need other's feedback and removed waiting for author need issue author's feedback labels Oct 21, 2022
@xgdyp xgdyp added this to the Add more community support milestone Oct 21, 2022
@xgdyp
Copy link
Contributor Author

xgdyp commented Oct 21, 2022

Thanks @bifenglin's advice. How about this? image

Hi @frank-zsy, do you think it's OK?

@frank-zsy
Copy link
Contributor

Yes, maybe this is a better way, and we can move related notebook and docker image scripts into the folder too since they are also language independent.

@github-actions github-actions bot added waiting for author need issue author's feedback and removed waiting for repliers need other's feedback labels Oct 21, 2022
@xgdyp
Copy link
Contributor Author

xgdyp commented Oct 21, 2022

OK, I'll work on this.

@github-actions github-actions bot added waiting for repliers need other's feedback and removed waiting for author need issue author's feedback labels Oct 21, 2022
@xgdyp
Copy link
Contributor Author

xgdyp commented Oct 21, 2022

/self-assign

@frank-zsy frank-zsy mentioned this issue Oct 26, 2022
Closed
@xgdyp xgdyp pinned this issue Nov 1, 2022
@frank-zsy
Copy link
Contributor

@xgdyp What's the progress here?

@github-actions github-actions bot added waiting for author need issue author's feedback and removed waiting for repliers need other's feedback labels Nov 7, 2022
@xgdyp
Copy link
Contributor Author

xgdyp commented Nov 7, 2022

Hi @frank-zsy , I'm still working on it. I'd finish this before Wednesday's biweekly meeting.

@github-actions github-actions bot added waiting for repliers need other's feedback and removed waiting for author need issue author's feedback labels Nov 7, 2022
@longyanz longyanz mentioned this issue Nov 8, 2022
Closed
@frank-zsy
Copy link
Contributor

Closed by #1035

@frank-zsy frank-zsy unpinned this issue Nov 18, 2022
@github-actions github-actions bot added waiting for author need issue author's feedback and removed waiting for repliers need other's feedback labels Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xgdyp xgdyp

Labels
kind/discussion Category issues related to discussion kind/question Category issues related to questions or problems waiting for author need issue author's feedback
Projects
None yet
Milestone
Add more community support
Development

No branches or pull requests
3 participants
@frank-zsy @xgdyp @zhicheng-ning